Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't delete the text while renaming a block, it instead closes the dialog & deletes the block. #61544

Closed
jeflopodev opened this issue May 10, 2024 · 2 comments · Fixed by #61583
Assignees
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@jeflopodev
Copy link

jeflopodev commented May 10, 2024

Description

I tried to rename a group block. I mistyped it and tried to delete some chars by pressing the Backspace key. The dialog then got closed on keypress, and my group block was deleted. Since I pressed it many times (to delete a few chars) the next focused blocks were deleted too. Pressing backspace once, still deletes the group block while renaming.

Step-by-step reproduction instructions

  1. While editing a template add a new group block
  2. Rename it
  3. Try to delete the text that you added in the input of the dialog by pressing the backspace.
  4. Check if the dialog is closed & the group block deleted on keypress and if further keypresses tries to delete rest of blocks.

Screenshots, screen recording, code snippet

5LPT1Fe.1.mp4

Environment info

  • Wordpress 6.5.3
  • Gutenberg 18.3.0
  • I tried that both in my custom theme and the Twenty Twenty-Four theme (without plugins other than Gutenberg)
  • Desktop Windows 11 23H2 22631.3527

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@jeflopodev jeflopodev added the [Type] Bug An existing feature does not function as intended label May 10, 2024
@mcsf
Copy link
Contributor

mcsf commented May 10, 2024

Bug introduced in #61130. /cc @Mamaduka

@Mamaduka
Copy link
Member

Thanks for the ping, @mcsf! I'll have a look as soon as possible.

@Mamaduka Mamaduka added the [Feature] List View Menu item in the top toolbar to select blocks from a list of links. label May 10, 2024
@Mamaduka Mamaduka self-assigned this May 10, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants