Add defaultFontSizes theme.json (theme.json v3) #58409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Type] Bug
|
This pull request changed or added PHP files in previous commits, but none have been detected in the latest commit. Thank you! ❤️ |
ajlende
force-pushed
the
fix/default-font-sizes-override
branch
from
37060a7
to
0333ef6
Compare
ajlende
changed the title
|
Size Change: +42 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ajlende
force-pushed
the
fix/default-font-sizes-override
branch
from
0333ef6
to
0c1707f
Compare
ajlende
force-pushed
the
fix/default-font-sizes-override
branch
from
0c1707f
to
561ba46
Compare
|
Flaky tests detected in ec14150. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8729353311
|
ajlende
force-pushed
the
fix/default-font-sizes-override
branch
2 times, most recently
from
fc92183
to
30e7c4f
Compare
ajlende
force-pushed
the
fix/default-font-sizes-override
branch
from
df86af6
to
661f0c0
Compare
ajlende
requested review from
spacedmonkey,
ellatrix,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@scruffian It looks like I missed updating some parts over the course of this being open while other PRs were merged and old behavior was changed. I've updated the screenshots and instructions to hopefully be more clear. Thanks for reviewing! |
ajlende
commented
Apr 17, 2024
|
|
||
| // Needs to be set for schema migrations of user data. | ||
| $config['isGlobalStylesUserThemeJSON'] = true; | ||
|
|
||
| static::$user = new WP_Theme_JSON_Gutenberg( $config, 'custom' ); |
There was a problem hiding this comment.
isGlobalStylesUserThemeJSON needs to be preset for migrations to run. Migrations are run on both WP_Theme_JSON_Data_Gutenberg and WP_Theme_JSON_Gutenberg constructors.
scruffian
approved these changes
Apr 19, 2024
|
Dev note draft 📝 Theme.json version 3The theme.json version has been incremented in order to update the default behavior for overriding the default Using older theme.json versions will continue to be supported and work the same as they have before. However, upgrading to version 3 is recommended when your minimum WordPress version reaches 6.6 because new development will continue in the newer versions. See the theme.json reference for more info on migration.
|
ajlende
added
the
has dev note
|
@ajlende The documentation updates look mostly good but there are some files that were not updated, and broken links. Needs updating:
|
|
JSON Schema no longer allows version 2. Shouldn't version 2 still be allowed?
|
While v2 theme.json files will continue to work on current versions of WordPress, the schema is a tool for theme developers to verify their theme.json with the specified version of WordPress you are developing for. Versions of schemas are handled via URL. For example, the last theme.json v2 schema will be located at I didn't do a great job of explaining this in the original theme.json blog post, but unless you are developing for folks with the Gutenberg plugin active, you don't really want to be using the Technically JSON Schema Draft-04 would be able to support all versions simultaneously, but it would be a nightmare to maintain, would be slower for code editors to check, and it wouldn't flag developers working off trunk of a new version where all new work is happening. |
@carolinan Thanks for catching those documentation issues. I found a bunch more issues as I was fixing those things and added everything in #61221. |
Mamaduka
reviewed
Apr 30, 2024
| @@ -2244,7 +2249,7 @@ | |||
| "version": { | |||
| "description": "Version of theme.json to use.", | |||
| "type": "integer", | |||
| "enum": [ 2 ] | |||
| "enum": [ 3 ] | |||
There was a problem hiding this comment.
I think we still need to support the older versions. Having only version 3 in the enum list produces a warning for default themes.
There was a problem hiding this comment.
Or should we increase the default theme's theme.json version to 3?
There was a problem hiding this comment.
I mentioned the default theme as an example. Not everyone will upgrade versions immediately, and the older versions still work.
There was a problem hiding this comment.
Default themes, like all other themes, should be using the schema for the oldest version of WordPress that they intend to support so that incompatible styles and settings are properly flagged. If the theme.json version is updated to 3, then the theme will only work with 6.6 and up or with the latest Gutenberg plugin installed.
It's confused often enough that I'm planning on writing a developer.wordpress.org blog post to help explain how JSON schema versioning works and how it's different from the theme.json version.
ajlende
changed the title
fabiankaegy
reviewed
May 2, 2024
| @@ -38,6 +38,7 @@ class WP_Theme_JSON_Schema_Gutenberg { | |||
| * Function that migrates a given theme.json structure to the last version. | |||
| * | |||
| * @since 5.9.0 | |||
| * @since 6.5.0 Migrate up to v3. | |||
fabiankaegy
reviewed
May 2, 2024
| * | ||
| * - Sets settings.typography.defaultFontSizes to false. | ||
| * | ||
| * @since 6.5.0 |
There was a problem hiding this comment.
Again I think this should be 6.6
justintadlock
added a commit
to x3p0-dev/x3p0-ideas
that referenced
this pull request
May 11, 2024
Use the new `defaultFontSizes` setting. We no longer need the `ThemeJson` class because its only purpose was to remove the Core default font sizes. Fixed in Gutenberg: WordPress/gutenberg#58409
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev Note 📝
See #58409 (comment)
What?
Reimplementation of #56661 with a proper theme.json migration.
Adds a
defaultFontSizesoption to disable showing the default font sizes.When
defaultFontSizes === falsethe options are removed from the UI.In theme.json v3, by default
defaultFontSizesistrue.In theme.json v2,
defaultFontSizesisn't a valid key, but is treated asfalsewhere it would be used when a theme has font sizes defined for backwards compatibility of generated CSS.Why?
Having an option for
defaultFontSizeswould give themes more control over which options are available. This option brings consistency to font sizes to match colors, gradients, duotone filters, and shadow presets.How?
Goals are to migrate the behavior of the font sizes presets to be like other presets that can be disabled via
default*settings.Testing Instructions
Screenshots below contain example modified
fontSizesJSON for TT4 to cover various cases of having font sizes and overriding default ones.For each modified theme.json test that each step works as expected (see screenshots):
"version": 2. (trunk and this PR should be the same.)"version": 3. (Don't forget to update the style variations too.)settings.typography.defaultFontSizestofalse.Then test custom origin styles migration.
"version": 2theme.json with no associatedwp_global_stylespost_types in the DB."version": 2entry in the DB."version": 3in the DB."defaultFontSizes": falseis not added to the entry in the DB."version": 3."defaultFontSizes": falseis still not added.Testing Instructions for Keyboard
N/A
Screenshots or screencast
Each set of screenshots shows a different example theme.json modification to TT4.
"defaultFontSizes": true.)false: Screenshot with"defaultFontSizes": falseset in v3 theme.json.TT4 Footnote Override
Example JSON
falseTT4 Custom Only
Example JSON
falseTT4 Empty
fontSizesExample JSON
falseTT4 Undefined
fontSizesExample JSON
false