Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin: Synchronize PHP changes for WordPress 6.5 release #57959

Closed
getdave opened this issue Jan 18, 2024 · 40 comments
Closed

Plugin: Synchronize PHP changes for WordPress 6.5 release #57959

getdave opened this issue Jan 18, 2024 · 40 comments
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@getdave
Copy link
Contributor

getdave commented Jan 18, 2024 •
edited by youknowriad

The issue tracks changes to PHP files that (might) need to be backported and merged to Core for the WordPress 6.5 release. The list is exhaustive so it may cover multiple PRs and experimental changes that won't be in 6.5.

Beta 1 is February 13, 2024

Tips 👀

  • Check whether files in your PR really do need backporting - if they don't please leave a comment to that effect and apply strikethrough to the line item in question.
  • Please open a new Core Trac ticket for each PR and link it next to the citation in this issue. 🙇
  • For ease of cross-linking and tracking, you can submit your PRs to WordPress/wordpress-develop. Refer to docs on how to fork the repository and create a PR. Link any backport PR next to the citation in this issue. 🙇
  • Try to limit PRs to one feature to make reviewing easier and the commit history clear. See why
  • Modifications/additions to PHP unit tests aren't listed: any unit tests introduced in the cited PRs should also be ported over where applicable. These are now listed 🎉
  • Once your backport PR is up, add it to the WordPress 6.5 Editor Tasks project board so folks can review it. Thank you!
  • PRs marked with ⚠️ may have previously been backported to WP Core. Please check these particularly carefully.

❗ This is a living document and will be constantly updated as we approach beta. Sorry if you were mistakenly pinged! If a file or files have already been backported, please tick them off and link to the backport PR/trac issue.

Or, if the changes are not slated for WordPress 6.5, you can strike them or make a comment in this issue. Thank you! 🙇

PRs to be backported will have the "Needs PHP backport" label applied.
Screenshot 2023-06-05 at 10 47 22 am

📁 lib

📁 block-supports

📄 shadow.php

📄 pattern.php

(this file has now been removed in trunk)

📄 typography.php

📄 layout.php

📄 background.php

📄 behaviors.php

📄 elements.php

📄 dimensions.php

📁 compat

📁 wordpress-6.5

📁 plugin

📁 experimental

📁 block-bindings

The Block Bindings API will be merged in WordPress/wordpress-develop#5888.

📁 interactivity-api

📁 fonts

Note: the Fonts Library will be backported in 3 PRs:

📁 modules

📁 fonts-api

the Fonts API has been deprecated and the files related to it will be removed once the Font Library is merged into Core

📁 sync

📄 blocks.php

📄 editor-settings.php

📄 class-gutenberg-rest-template-revision-count.php

📄 data-views.php

📄 client-assets.php

📄 class-wp-theme-json-gutenberg.php

📄 blocks.php

📄 init.php

📄 global-styles-and-settings.php

📄 class-wp-theme-json-resolver-gutenberg.php

📄 class-wp-duotone-gutenberg.php

📁 phpunit

📁 packages

📁 style-engine

📄 class-wp-style-engine.php
@getdave getdave added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. labels Jan 18, 2024
@gaambo

This comment was marked as resolved.

Sign in to view
@t-hamano

This comment was marked as resolved.

Sign in to view
@andrewserong
Copy link
Contributor

Thanks for the pings, Dave! 🙇 I've double-checked that we've already done all the background image backports, but I'd missed a small layout backport. I've opened a core PR in WordPress/wordpress-develop#5900 for trac ticket 60292 for that one.

@Mamaduka

This comment was marked as resolved.

Sign in to view
@ntsekouras

This comment was marked as resolved.

Sign in to view
@kt-12

This comment was marked as resolved.

Sign in to view
@getdave getdave mentioned this issue Jan 19, 2024
Merged
@mikachan
Copy link
Member

My understanding is that the code regarding the Font Library (lib/experimental/fonts, phpunit/tests/fonts/font-library) does not exist in the core at all yet. If we ship the font library to WP6.5, can it be backported in one PR?

@t-hamano Thanks for checking this! Yes, the current plan is to backport everything for the Font Library in one PR.

@mikachan

This comment was marked as resolved.

Sign in to view
@youknowriad
Copy link
Contributor

@mikachan when can we expect the font library merge? Can we accelerate there a little bit, even if it means we follow-up with bug fixes?

@mikachan
Copy link
Member

when can we expect the font library merge?

We're planning on opening a Core PR as soon as this feature branch is merged into GB trunk. We're planning on doing this no later than Tuesday 23 Jan, but it's reliant on how quickly we can receive feedback on that branch.

@youknowriad
Copy link
Contributor

@mikachan Great, let me know if you need help ensuring people give the feedback on time :)

@anton-vlasenko

This comment was marked as resolved.

Sign in to view
@artemiomorales

This comment was marked as resolved.

Sign in to view
@tellthemachines

This comment was marked as resolved.

Sign in to view
@tellthemachines

This comment was marked as resolved.

Sign in to view
@michalczaplinski

This comment was marked as resolved.

Sign in to view
@aristath

This comment was marked as resolved.

Sign in to view
This was referenced Jan 22, 2024
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 26, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@luisherranz

This comment was marked as resolved.

Sign in to view
@youknowriad
Copy link
Contributor

I've committed the initial package update PR, if you had a backport that was waiting for it, you can now go ahead and move forward with it.

It's also a good time to start testing all of your features on WordPress Core with the plugin disabled to check that we didn't miss any backports or anything.

@getdave getdave mentioned this issue Jan 30, 2024
Merged
@t-hamano
Copy link
Contributor

In #58426, it was found that the navigation view script may not be loaded in WP6.5 alpha. Does this have something to do with backporting PHP?

@youknowriad
Copy link
Contributor

@t-hamano I think it's related yes. I'm working with @luisherranz today to try to fix the interactive blocks.

This was referenced Jan 31, 2024
Merged
Merged
@youknowriad
Copy link
Contributor

@t-hamano It should be fixed in WordPress/wordpress-develop#5984

@luisherranz
Copy link
Member

luisherranz commented Jan 31, 2024 •
edited

The import map polyfill was committed yesterday. Only one backport left on our side:

  • Interactivity API: Server Directive Processing: Trac - PR

@t-hamano t-hamano mentioned this issue Jan 31, 2024
Open
@sirreal
Copy link
Member

sirreal commented Jan 31, 2024

WordPress/wordpress-develop#5860 is open to backport #57437 and needs review.

@ramonjd ramonjd mentioned this issue Jan 31, 2024
Merged
This was referenced Feb 1, 2024
Merged
Merged
Merged
@michalczaplinski
Copy link
Contributor

michalczaplinski commented Feb 1, 2024 •
edited

WordPress/wordpress-develop#5888 has been merged so I've marked the Block Bindings-related PRs as "backported".

@getdave getdave mentioned this issue Feb 1, 2024
Merged
@ajlende
Copy link
Contributor

ajlende commented Feb 2, 2024

WordPress/wordpress-develop#5979 is open to backport some theme.json PHPUnit tests and it could use some 👀.

@aaronrobertshaw
Copy link
Contributor

WordPress/wordpress-develop#6053 is available to backport a recent fix to block style variations selectors in the theme.json class.

@talldan
Copy link
Contributor

talldan commented Feb 7, 2024

I've just opened a new backport PR for pattern overrides - WordPress/wordpress-develop#6055

@matiasbenedetto
Copy link
Contributor

The font library has been ported into core in these 3 PRs:

@gziolo
Copy link
Member

gziolo commented Feb 8, 2024

I landed today WordPress/wordpress-develop#5953 and marked related files as synced for Interactivity API. I also marked other files related to the project that were missed.

@youknowriad
Copy link
Contributor

Thanks everyone for your help here. We managed to backported everything on time without too much issues.

Follow-up work:

  • We invite you all to test your work on WordPress trunk (without the Gutenberg plugin) and ensure that everything is working as expected.
  • We invite you all to check the 6.5 project board and triage/close/punt the issues that you're familiar with and address the bugs ("Todo" column specifically)
  • From now on, I invite you to add the "Backport to WordPress Beta/RC" label to all of your PRs (mostly bug fixes at this points) that need to be included in WordPress 6.5.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
WordPress 6.5 Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests