Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Review pattern performance (at scale, various inserters, etc) #54704

Open
annezazu opened this issue Sep 21, 2023 · 3 comments
Open
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Performance Related to performance efforts

Comments

@annezazu
Copy link
Contributor

annezazu commented Sep 21, 2023

Pulled from this prior issue #27890, I wanted to surface this as a task for @WordPress/performance / @oandregal to consider partially too as a follow up to this recent performance problem and fix #50695

Patterns continue to play an important role in the future of WordPress so let's ensure they are performant at scale! This includes using lots of them and in exploring how performant they are across different Inserters.

@annezazu annezazu added [Type] Performance Related to performance efforts [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Sep 21, 2023
@glendaviesnz
Copy link
Contributor

glendaviesnz commented Sep 24, 2023

This has hopefully been resolved by #54007 which added paging to the pattern list pages client side in the post editor inserter. I think the issue was mostly client-side with the browser struggling to render so many patterns, rather than a server response time issue, but it would be worth testing and clarifying this so we can decide if we also want to page the server responses.

@mslinnea
Copy link

I created 5000 synced patterns that were all very simple (each pattern just a couple of paragraphs), and I didn't run into the browser crashing or any noticeable issue, so I'd agree it likely relates to the browser trying to render so many patterns. The pagination in #54007 sounds promising.

@annezazu annezazu changed the title Performance: Review cases with 1000+ synced patterns for performance bottlenecks Performance: Review pattern performance (at scale, various inserters, etc) Oct 24, 2023
@draganescu
Copy link
Contributor

draganescu commented Oct 26, 2023

This will probably be solved by #54999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Performance Related to performance efforts
Projects
Status: No status
Development

No branches or pull requests

4 participants