Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace forked mobile editor dependencies #53359

Open
2 of 5 tasks
dcalhoun opened this issue Aug 4, 2023 · 1 comment
Open
2 of 5 tasks

Replace forked mobile editor dependencies #53359

dcalhoun opened this issue Aug 4, 2023 · 1 comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Build Tooling Issues or PRs related to build tooling

Comments

@dcalhoun
Copy link
Member

dcalhoun commented Aug 4, 2023

This issues tracks various tasks for removing forked, third-party dependencies for the native mobile editor. The following tasks could likely be addressed individually as miniature projects.

What problem does this address?

The forked dependencies have caused issues in the past, e.g. #33424, #40540. We have adapted our approach to work around these issues, but the forked dependencies remain an inefficiency.

Current State

Dependency Modify iOS Modify Android Modify Javascript Removal Difficulty
react-native-reanimated 1     Low
react-native-prompt-android     High
react-native-video   High
react-native-slider   Low
react-native-hsv-color-picker     ✅~ Medium

What is your proposed solution?

We could remove dependency on the forked dependencies by committing fixes/required changes to the upstream repositories or internalizing the dependency in the form of implementing the dependency in the Gutenberg code directly.

Footnotes

  1. The modification is made to Podfile to fix an actual issue from the upstream repository.

@dcalhoun dcalhoun added [Type] Build Tooling Issues or PRs related to build tooling Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. labels Aug 4, 2023
@dcalhoun
Copy link
Member Author

Noting that react-native-prompt-android was removed in #54096.

@twstokes twstokes removed the [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

No branches or pull requests

2 participants