Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duotone filter not showing on Covers inside Query Loops #50828

Open
henriqueiamarino opened this issue May 22, 2023 · 11 comments
Open

Duotone filter not showing on Covers inside Query Loops #50828

henriqueiamarino opened this issue May 22, 2023 · 11 comments
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Query Loop Affects the Query Loop Block [Type] Bug An existing feature does not function as intended

Comments

@henriqueiamarino
Copy link

Description

As I am exploring different ways to use Cover blocks I may have found a possible bug. I am using Covers inside Query loops (Query loops > Post template > Cover) and duotone filters set to those covers do not show in Frontend site.
While previewing in the Editor they are there but once published the site they're gone.

The issue is repeated in two different sites, both Jazzers and Nested.

We had a discussion about it on this Slack thread but we couldn't get to a solution.

Step-by-step reproduction instructions

  1. Create a group on the root and add a Query Loop to it;
  2. Inside Post Template add a Cover and pull the post content into this cover;
  3. Add a duotone filter to this Cover. Please test with duotones available on preset and custom colors;
  4. Check the published site.

Screenshots, screen recording, code snippet

May22_cover-duotone_fail

Check the site here: https://jazzers.mystagingwebsite.com/

Environment info

  • WordPress 6.2.2, Gutenberg 15.8.1
  • Create Block Theme generated theme called Jazzers

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@mrfoxtalbot mrfoxtalbot added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Query Loop Affects the Query Loop Block [Type] Bug An existing feature does not function as intended labels May 22, 2023
@mrfoxtalbot
Copy link

mrfoxtalbot commented May 22, 2023

Mmmm... I tried to replicate this but it seems to be working correctly on my end. Here's an example from one of my testing sites:

https://twentytwenty.mystagingwebsite.com/2023/

Screen Shot on 2023-05-22 at 16:47:11

Any thoughts on what could I be missing @henriqueiamarino? Thank you!

@mrfoxtalbot mrfoxtalbot added Needs Design Needs design efforts. Needs Testing Needs further testing to be confirmed. and removed Needs Design Needs design efforts. labels May 22, 2023
@henriqueiamarino
Copy link
Author

I really have no clue @mrfoxtalbot. I'll attach some thoughts from a teammate in a conversation we had a couple of days ago. In time, did you try some custom colors instead of this Blue and Red available on preset?

Screenshot 2023-05-22 at 17 54 36

@mrfoxtalbot
Copy link

Thank you @henriqueiamarino. So it does sound like Joen can replicate it, right? 🤔

@github-actions
Copy link

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Jun 22, 2023
@priethor priethor removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Jun 30, 2023
@github-actions
Copy link

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Jul 31, 2023
@jordesign
Copy link
Contributor

@henriqueiamarino @jasmussen Just checking back on this to see if you're still able to recreate this issue with the Cover Block?

@jordesign jordesign removed Needs Testing Needs further testing to be confirmed. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. labels Oct 26, 2023
@henriqueiamarino
Copy link
Author

henriqueiamarino commented Jan 12, 2024

@mrfoxtalbot @jordesign I'd appreciate it if you could test the theme and see if there's something you can do. No, it is not fixed; the duotones are there while you use the Editor but still doesn't work on the frontend.
Here's the theme design: jazzers.zip

I remember @jasmussen mentioned an issue here. Can I actively do something to fix this?

@henriqueiamarino
Copy link
Author

In time, I discovered that once I disable Fixed background and Repeat background on Media Settings, the duotones show up on the frontend. It's not a fix but it's good enough to be shipped — and I'll do that.

Screenshot 2024-01-12 at 10 07 29

@jasmussen
Copy link
Contributor

Hmm that's curious, I can still use a cover image with a duotone background that is fixed position in my blink and safari browsers. 🤔

@iamtakashi
Copy link

iamtakashi commented Apr 27, 2024

The duotone filter seems to be broken when the cover block uses a featured image with a fixed background setting on. The breakage appears only on the front of the site. It works in the editor.

CleanShot 2024-04-27 at 19 08 40@2x

The selectors to apply the filter don't catch the markup in that case (using the F.I. + fixed background.)

@jasmussen
Copy link
Contributor

@ajlende any instincts on what might be going on here? Thanks for looking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Query Loop Affects the Query Loop Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

6 participants