Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Gradient background color repeats #46782

Closed
t-hamano opened this issue Dec 25, 2022 · 7 comments · Fixed by #51374
Closed

Site Editor: Gradient background color repeats #46782

t-hamano opened this issue Dec 25, 2022 · 7 comments · Fixed by #51374
Assignees
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

Description

Might be related to #44374

In the global style, repetition may occur when the body has a gradient background color. This seems to occur when the block content is less than the height of the iframe area.

Step-by-step reproduction instructions

  • Activate Twenty Twenty Three.
  • Open the site editor and enter the edit mode with the Blank template.
  • apply the Sherbet style.
  • In zoomed-out view, the content area is heighted to fit the block and no background repetition occurs.
  • When you return to edit mode and insert any block (or after a short time), the background will expand to full height and you will see the background image repeat itself.

Screenshots, screen recording, code snippet

f72b9358f53724bf3e5d34b1ad90be75.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Dec 25, 2022
@t-hamano
Copy link
Contributor Author

Perhaps this problem is not limited to gradient backgrounds. When returning from a zoomed-out view, the height of the content switches unsteadily.

9b27a597361f8b853994eec4080ef87a.mp4

@t-hamano t-hamano self-assigned this Dec 25, 2022
@annezazu
Copy link
Contributor

This was reported as part of the nineteenth call for testing for the FSE Outreach Program:

Theme seems to have a dark mode view that appears to be broken when you’re editing a template part. It’s unclear if the ridges are the expected behavior

Screenshot 2022-12-27 at 17 58 41 2022-12-27 at 7 05 23 PM

@n-els
Copy link

n-els commented Apr 20, 2023

What is the current status, I still have this problem.

@annezazu
Copy link
Contributor

This is still an active issue, meaning it has yet to be fixed.

@priethor
Copy link
Contributor

priethor commented May 8, 2023

@t-hamano are you still interested in working on this issue?

@t-hamano
Copy link
Contributor Author

I apologize for the delay in responding, even though I have assigned myself.

I have not yet found the ideal solution, but I will work on it as a high priority. If you all have a good approach, I would welcome PR 🙏

@priethor
Copy link
Contributor

Thanks, Aki; no worries! I just wanted to know if it's still on your radar 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants