link icon missing in block editor

[genem80]

Description

On 12/19/22 when I highlight text I can add a link or edit an existing link with the link icon. On 12/21/22 the link icon no longer exists when I highlight text. Version 14.8.0 was the gutenberg version. I just checked version 14.8.1 and the link icon is still missing.

Step-by-step reproduction instructions

1.Create a paragraph block
2. type some text
3. Highlight the text
4. The toolbar that pops up does not have the link icon

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[t-hamano]

I have tested with Guetnberg 14.8.1 and it appears to be working as expected.
Am I missing something?

[smtping]

I have the same problem too, here is a screenshot

[smtping]

Well, I disabled gutenberg now and it works like before (@genem80 keep it disabled)

[t-hamano]

@smtping
Thanks for the info.
However, I could not reproduce the problem in my environment even after activating the latest Gutenberg 🤔

[genem80]

So I deactivated gutenberg as @smtping said and the link icon returns (thanks @smtping). I'm relatively new to WP, so what am I losing by not using the gutenberg plugin. Do a base set of gutenberg block editing features come built in with WP?

[xoex]

I can confirm I have this problem too, sometimes url button is exist, but most of times it's not.
I got this error in console :

register-format-type.js:86 Format "core/unknown" is already registered to handle bare tag name "a".

P.S: I can't edit other links from previous posts, It shows error formatting.

[smtping]

@xoex just keep it disabled (keep the classic editor disabled too). I think that with the last update it became embedded (by default) with wordpress

[t-hamano]

I have enabled Gutenberg version 14.8.1 on a clean install of WordPress 6.1.1 and still cannot reproduce the problem. Is there any improvement by disabling plugins other than Gutenberg and changing to the default theme?

[xoex]

@xoex just keep it disabled (keep the classic editor disabled too). I think that with the last update it became embedded (by default) with wordpress

Best was rollback to previous version for me. But problem is really there,

[gyurmey2]

I confirm that the problem exists.
Gutenberg version: 14.9.20221224

[t-hamano]

I have not yet found the conditions to reproduce this problem, but since it is considered a major problem, I would assign the label "[Priority] High".

[t-hamano]

If possible, we would appreciate it if you could provide us with the following information:

• Does this happen even if I disable all plugins except the Gutenberg plugin and change to the default theme?
• Are there any error messages in your browser's console log? For example, like the one mentioned in this comment.

[Gierand]

@t-hamano, I noticed the same problem, but the Rank Math SEO plugin is responsible for it.

[t-hamano]

@Gierand
Thanks to you I was able to reproduce this problem!

This plugin remove the core inline link and add its own inline link control. It appears that perhaps due to #44086, we can no longer re-register format types with the same settings s that don't have className.

This problem can be reproduced in the browser console.

Without Gutenberg Plugin 14.8.1

The format type is successfully registered.

WordPress6.1.1 with Gutenberg Plugin 14.8.1

Format type registration fails.

[genem80]

I don't use the "Rank Math SEO" plugin. I do use the "All in One SEO" plugin so I don't know if the same issue occurs there. Some basic questions on plugins:

1. Are there guidelines that all plugin developers need to follow so as not to step on each other toes
2. Do you do extensive regression testing on new releases against a variety of theme/plugin combinations? I think it's not reasonable for users to do this type of QA for you.

[Thelmachido]

I can't reproduce the issue, however, we have 4 other reports on the Gutenberg Forums with the same issue.

1. https://wordpress.org/support/topic/cant-add-links-to-posts-link-button-is-missing/
2. https://wordpress.org/support/topic/clear-unknown-formatting-instead-of-a-link-button/

One of the folks noticed that the link option comes back when the Rank Math Seo plugin is deactivated so they reach out to them here: https://wordpress.org/support/topic/conflicts-with-gutenberg-cant-add-links/

[t-hamano]

@Thelmachido
Thank you for the report.

As I understand it, the problem is that the latest Gutenberg doesn't allow registering format types that don't have a className. I expect that the users reported in the forum have probably disabled the core link functionality and are using their own link formats.

I would again mark this issue as a high priority.

[davilera]

I think my PR #46798 fixes the issue. Can anybody please confirm?

[noahtallen]

I verified the fix and merged it. Thanks @davilera! I'll work on creating a patch release for 14.8 now.

[noahtallen]

This should now be fixed in Gutenberg v14.8.2! Of course, please let us know if there are still issues.