Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Cover Block placeholder for consistency with the Image Block #46042

Open
priethor opened this issue Nov 24, 2022 · 3 comments
Open

Update the Cover Block placeholder for consistency with the Image Block #46042

priethor opened this issue Nov 24, 2022 · 3 comments
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement.

Comments

@priethor
Copy link
Contributor

What problem does this address?

Since the Image block placeholder state was improved in #43180, the Cover block placeholder is not consistent with the Image block's anymore, despite having a very similar interface when focused during their setup stage:

Grabacion.de.pantalla.2022-11-24.a.las.17.21.59.mov

What is your proposed solution?

The Cover Block placeholder state could show a placeholder image instead of the setup options, similar to how the Post Featured Image block and the Image block's placeholders work.
@priethor priethor added [Type] Enhancement A suggestion for improvement. [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Nov 24, 2022
@richtabor
Copy link
Member

Came here to report this inconsistency as well.

@richtabor
Copy link
Member

The core/media-text block is also behind:

CleanShot 2023-04-11 at 17 16 55

@jordesign
Copy link
Contributor

Worth noting that the 'Insert from URL' could be an interesting addition here as well.
#47355

@jordesign jordesign mentioned this issue Sep 8, 2023
Closed
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richtabor @jordesign @priethor