Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments Form: lack of padding creates bad layout when changing colors #45085

Closed
annezazu opened this issue Oct 18, 2022 · 0 comments · Fixed by #45091
Closed

Comments Form: lack of padding creates bad layout when changing colors #45085

annezazu opened this issue Oct 18, 2022 · 0 comments · Fixed by #45091
Assignees
@carolinan
Labels
[Block] Post Comments Form Affects the Comments Form Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

With 6.1 RC2, if I add custom colors to the comments form, the outcome is really poor with an inability to customize the padding/margin further. In time, this can be addressed with #43243 but, for now, the experience is pretty out of the box bad without it:

Screen Shot 2022-10-18 at 4 19 29 PM

Screen Shot 2022-10-18 at 4 19 53 PM

What is your proposed solution?

I wonder if we should inherently add some padding to the block to improve the default design ahead of the full design tools being added.
@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Post Comments Form Affects the Comments Form Block labels Oct 18, 2022
@carolinan carolinan mentioned this issue Oct 19, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 19, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carolinan carolinan

Labels
[Block] Post Comments Form Affects the Comments Form Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Post comments form: Add spacing support WordPress/gutenberg
3 participants
@carolinan @annezazu @priethor