Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding/Margin visualizer: Incorrect position when scrolled partially past element #44977

Closed
jasmussen opened this issue Oct 14, 2022 · 1 comment · Fixed by #44998
Closed
Assignees
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Bug An existing feature does not function as intended

Comments

@jasmussen
Copy link
Contributor

The margin and padding visualizations are the blue overlays that appear on the inside and outside of a block when manipulating margins and paddings.

If you tweak the margins and paddings on a long group, long enough that you may have scrolled partially by it, the visualization can be incorrect. Here's a GIF of a long group and showing how the viewport scroll position affects the placement of the overlay:

visualization bug

The same applies for padding:

padding

Steps to reproduce:

  • Have a group with a lot of content inside
  • Select the group, scroll partially down the page so the block toolbar detaches
  • Use the padding or margin tools and observe a mis-placed padding/margin
Test content

paragraph

paragraph

paragraph

paragraph

paragraph

multiple paragraphs, enough that you can scroll partly through this group

2

4

5

6

7

8

9

10

11

12

13

14

paragraph

paragraph

paragraph

paragraph

paragraph

paragraph

paragraph

paragraph

paragraph

paragraph

@jasmussen jasmussen added [Type] Bug An existing feature does not function as intended [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Oct 14, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 16, 2022
@BE-Webdesign
Copy link
Contributor

#44998 Fixes this.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Bug An existing feature does not function as intended
Projects
None yet
3 participants