Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a template: Present the user with initial block configuration options #41060

Closed
2 tasks done
Tracked by #41241
jameskoster opened this issue May 13, 2022 · 45 comments
Closed
2 tasks done
Tracked by #41241
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")

Comments

@jameskoster
Copy link
Contributor

jameskoster commented May 13, 2022

When possible we suggest patterns during the page creation flow. This can help speed up the addition of pages, and provide some creative inspiration.

It would be good to do the same thing when creating a new template. It's not yet possible to associate a pattern with a template, so we'll need to split this into two parts:

For part one, we'll display something like this after the template is created:

Screenshot 2022-11-23 at 14 07 51

This will be augmented with additional patterns for part two:

Screenshot 2022-11-23 at 14 09 35

Somewhat related: #39308

@jameskoster jameskoster added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label May 13, 2022
@jameskoster jameskoster added the Needs Design Needs design efforts. label May 13, 2022
@annezazu

This comment was marked as off-topic.

@jameskoster

This comment was marked as off-topic.

@annezazu

This comment was marked as off-topic.

@carolinan

This comment was marked as outdated.

@jameskoster

This comment was marked as outdated.

@mtias

This comment was marked as outdated.

@mtias

This comment was marked as outdated.

@mtias

This comment was marked as outdated.

@jameskoster jameskoster changed the title Creating a template: Present the user with initial block configurations Creating a template, header, or footer: Present the user with initial block configurations May 23, 2022
@jameskoster jameskoster changed the title Creating a template, header, or footer: Present the user with initial block configurations Creating a template, header, or footer: Present the user with initial block configuration options May 23, 2022
@carolinan

This comment was marked as outdated.

@jameskoster

This comment was marked as outdated.

@mtias

This comment was marked as off-topic.

@DaisyOlsen

This comment was marked as off-topic.

@jameskoster

This comment was marked as outdated.

@jameskoster jameskoster added the Needs Design Feedback Needs general design feedback. label May 25, 2022
@beckej13820

This comment was marked as outdated.

@jameskoster

This comment was marked as outdated.

@jorgefilipecosta
Copy link
Member

Because choosing the template type is only the first step, after which you still need to design the template. A 404 template for example can have endless configurations, which is why we present patterns.

So on the add new template the user chooses the template type e.g: 404, or single post and chooses a pattern for that template (or blank if the user really wants blank) the site editor loads the new created template with the choose pattern. In which case we would show another modal to choose a pattern? The user already choose a pattern before.
If the idea is really to have two modals and choose patterns two times, for the 404 template type could you given examples of patterns the user would choose on the add new template modal, and the patterns the user would choose after the site editor loads? Are they the same patterns?

@jameskoster
Copy link
Contributor Author

No, the user should not be choosing the pattern twice 😭

Template selection and pattern selection are separate parts of the same overall flow. That is:

  1. Click Add New template
  2. Choose the template e.g. Page
  3. Choose whether to create the generic page template, or to create a template for a specific page
  4. Select the specific page you want to create the template for
  5. You're sent to the Editor and a modal appears containing patterns for displaying a page

This issue concentrates purely on that fifth step. Steps 1 through 4 need more design work. Sorry for the confusion here.

@ndiego
Copy link
Member

ndiego commented Feb 10, 2023

@jameskoster @jorgefilipecosta Just checking in to see if we still aiming for 6.2 with this? Thanks!

@jameskoster
Copy link
Contributor Author

The first task was merged last week (#46248), and I think that can be included in 6.2.

@jorgefilipecosta can confirm, but I don't believe the second task was factored into the work in that PR, so we probably need to leave the issue open.

@ndiego
Copy link
Member

ndiego commented Feb 23, 2023

@jameskoster #46248 was included in Gutenberg 15.2 (not included in 6.2), and I do not believe it was backported to the 6.2 Betas. @Mamaduka @ntsekouras are you able to confirm this?

@Mamaduka
Copy link
Member

Gutenberg 15.2 was released yesterday; we need more time to test #46248 to be included in the release IMO. So I would recommend punting this for WP 6.3.

@ntsekouras
Copy link
Contributor

This is punted already since: #48077, that moved the files in compat/6.3.

@jameskoster
Copy link
Contributor Author

Dang, that's a shame. 46248 softened a number of rough edges in the template creation flow 😓

@jameskoster jameskoster added the Needs Dev Ready for, and needs developer efforts label Mar 22, 2023
@SaxonF
Copy link
Contributor

SaxonF commented Mar 28, 2023

You're sent to the Editor and a modal appears containing patterns for displaying a page

@jameskoster do you think this should be part of the new drill-down experience vs a modal? Another option is just opening inserter in editor as this helps from an educational aspect as well. This is where some guidelines around site editor sidebar vs editor would help us decide where an experience like this should live.

image

@jameskoster
Copy link
Contributor Author

@jameskoster do you think this should be part of the new drill-down experience vs a modal?

Yes, we should explore that.

Another option is just opening inserter in editor as this helps from an educational aspect as well.

Maybe it's reachable in both places 🙊 The 'full-page' patterns will be available in the Inserter regardless. And surfacing them in the dark material could be nice as well, because it's not beyond the realms of possibility that it'd enable you to create a template without having to invoke the full screen editor at all.

@jameskoster jameskoster removed the Needs Dev Ready for, and needs developer efforts label Mar 28, 2023
@jameskoster
Copy link
Contributor Author

@SaxonF are you seeing the "Apply template to" dropdown containing the options from this menu?

Screenshot 2023-03-29 at 19 17 59

I'm curious how we'd present 'custom' templates.

The starting points will update as you work through the form so we might need a loading state. Could be worthwhile to quickly prototype this one.

@SaxonF
Copy link
Contributor

SaxonF commented Mar 30, 2023

are you seeing the "Apply template to" dropdown containing the options from this menu?

Previously shared this somewhere else so obviously doesn't reflect dark mode but the idea is that rather than trying to explain the complex template hierarchy in a single dropdown we take a more natural language approach by splitting into two inputs. custom templates would be the bottom option of the first input.

template-create.1.mp4

@jameskoster
Copy link
Contributor Author

Yeah, it's quite tricky to support the full expressiveness of the template hierarchy and present it in a way that feels intuitive :)

I like the natural language, but I'm missing ways to create a template for a post tag or category, or for a specific author.

Another idea to avoid overwhelming in that first dropdown could be to center its contents around post types, and reveal subsequent dropdowns based on the initial selection, kind of like a filter:

Filter

It seems that whichever way we slice it, it comes down to: Fewer dropdowns with longer menus. More dropdowns with shorter menus.

@SaxonF
Copy link
Contributor

SaxonF commented Mar 30, 2023

I like that. To me it feels more intuitive as it focuses more on the outcome vs trying to gauge the outcome from template name + description. We can also be clever about certain selections e.g. decide whether to use home or front-page based on site configuration.

@jameskoster
Copy link
Contributor Author

One other thing that came up in a discussion with @jasmussen today was a need for a more comfortable way to browse many starting points. Perhaps something like the pattern directory modal?

@jasmussen
Copy link
Contributor

This is the mockup we discussed:

Editor

Note that I don't consider it a particularly good design: the "Start blank" could arguably be a blank page inside, the modal is a bit big and unstyled, etc. — but it's spacious.

Even if we do keep things in the drilldown detail pages, which I think brings with it a lot of solid benefits, a modal like this could potentially be an extra affordance. Maybe.

@jameskoster
Copy link
Contributor Author

Yup that's what I meant: an additional affordance, similar to the "Explore all patterns" button in the Inserter 👍

@jameskoster
Copy link
Contributor Author

There have been conversations about moving the pattern selection process to the sidebar, which is a bit related to #50739.

But since pattern suggestions are now displayed (both fall backs and contextual), I think we can close this issue.

Screenshot 2023-05-18 at 18 57 57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")
Projects
Status: Done
Status: Done
Development

No branches or pull requests