Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-existent time in Block Library (String error in WordPress 6.0 RC) #40916

Closed
tobifjellner opened this issue May 8, 2022 · 3 comments · Fixed by #40929
Closed

Non-existent time in Block Library (String error in WordPress 6.0 RC) #40916

tobifjellner opened this issue May 8, 2022 · 3 comments · Fixed by #40929
Labels
Needs Testing Needs further testing to be confirmed.

Comments

@tobifjellner
Copy link
Contributor

Description

The cherry-picked Gutenberg blocks for WordPress 6.0 include the following string:
January 1, 2000 at 00:00 am

Note that IF am/pm is used, then there is no hour "00", but should be 12:00 am.
If this string is only displayed, then this is mostly a cosmetic problem, but if the string is going to be construed by software, then this might raise warnings and/or eyebrows.

I found string while checking translations for WordPress 6.0. The source reference is https://build.trac.wordpress.org/browser/trunk/wp-includes/js/dist/block-library.js?marks=31215#L31215

Step-by-step reproduction instructions

N/A

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@amustaque97 amustaque97 added the Needs Testing Needs further testing to be confirmed. label May 8, 2022
@talldan
Copy link
Contributor

talldan commented May 9, 2022

I think it was introduced here - #40484

cc @luisherranz

@luisherranz
Copy link
Member

If this string is only displayed, then this is mostly a cosmetic problem

Yes, it's just for a placeholder, but I'll add a PR to fix it. Thanks for the heads up 🙂

@luisherranz
Copy link
Member

PR opened: #40929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing Needs further testing to be confirmed.
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants