Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Deprecate outer margins #39358

Open
17 of 20 tasks
mirka opened this issue Mar 10, 2022 · 0 comments
Open
17 of 20 tasks

Components: Deprecate outer margins #39358

mirka opened this issue Mar 10, 2022 · 0 comments
Labels
[Package] Components /packages/components [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@mirka
Copy link
Member

mirka commented Mar 10, 2022

What problem does this address?

A lot of components currently have inherent outer margins, making it hard to reuse in different contexts since it requires a style override (often of an internal element). This kind of style override is something we want to discourage.

What is your proposed solution?

Deprecate the bottom margin (similar to #37160), following the guidelines stipulated in the devdocs.

Components

Each component first needs a __nextHasNoMarginBottom prop to opt in, and then they also need to be officially deprecated after all in-repo usage has been migrated.

Block Editor Components

(Component lists may not be exhaustive, please add)

@mirka mirka added [Package] Components /packages/components [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. labels Mar 10, 2022
@mirka mirka added this to Inbox (needs triage) 📬 in WordPress Components via automation Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
WordPress Components
Inbox (needs triage) 📬
Development

No branches or pull requests

1 participant