Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Welcome's panel "Edit styles" link does not seem to work #38090

Closed
audrasjb opened this issue Jan 19, 2022 · 3 comments · Fixed by #38093
Closed

New Welcome's panel "Edit styles" link does not seem to work #38090

audrasjb opened this issue Jan 19, 2022 · 3 comments · Fixed by #38093
Assignees
@noisysocks
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
WordPress 5.9 Must-Haves

Comments

@audrasjb
Copy link
Contributor

Description

The expected behavior would be to open the Global Styles panel on the site editor.

Original Trac ticket: https://core.trac.wordpress.org/ticket/54859

Step-by-step reproduction instructions

  1. On WP 5.9 RC3 Welcome panel, click "Edit styles" link.
  2. It leads to the site editor, but it doesn't open the Global Styles panel, which would be the expected behavior.

Screenshots, screen recording, code snippet

No response

Environment info

  • WP 5.9 RC 3, no plugin.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@hellofromtonya hellofromtonya added this to 📥 To do in WordPress 5.9.x via automation Jan 19, 2022
@hellofromtonya hellofromtonya added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended labels Jan 19, 2022
@hellofromtonya
Copy link
Contributor

As I noted in the Trac ticket, this issue may be a bad URL. The one used is: wp-admin/site-editor.php?styles=open. Is this correct to automatically open the Styles area in the Site Editor? Or is this a bug that needs fixing?

It would be great to have this issue fixed quickly in case another issue is reported that warrants a RC4. cc @noisysocks @Mamaduka

@noisysocks
Copy link
Member

That URL is correct. It looks like this functionality was accidentally removed in #36637. I'll open a PR to add it back.

@noisysocks noisysocks removed this from 📥 To do in WordPress 5.9.x Jan 19, 2022
@noisysocks noisysocks added this to 📥 To do in WordPress 5.9 Must-Haves via automation Jan 19, 2022
@noisysocks noisysocks moved this from 📥 To do to 🏗️ In progress in WordPress 5.9 Must-Haves Jan 19, 2022
@noisysocks noisysocks mentioned this issue Jan 19, 2022
Merged
8 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 19, 2022
@audrasjb
Copy link
Contributor Author

Alright, thank you!

WordPress 5.9 Must-Haves automation moved this from 🏗️ In progress to ✅ Done Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noisysocks noisysocks

Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 5.9 Must-Haves
✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Site Editor: Restore ?styles=open functionality WordPress/gutenberg
3 participants
@noisysocks @audrasjb @hellofromtonya