Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Add Block" button at the end of the inner block is not displayed. #37938

Closed
ddryo opened this issue Jan 13, 2022 · 5 comments
Closed

The "Add Block" button at the end of the inner block is not displayed. #37938

ddryo opened this issue Jan 13, 2022 · 5 comments
Labels
[Block] Group Affects the Group Block

Comments

@ddryo
Copy link
Contributor

ddryo commented Jan 13, 2022

Description

When editing an inner blocks in a Group block, etc., the "Add Block" button that used to appear at the bottom of the last block is no longer displayed in WordPress 5.9.

It is now very difficult to add a new block when placing anything other than a "block that can generate the next block on a new line" such as a Paragraph block.

Step-by-step reproduction instructions

  1. For example, place a Paragraph block and an Image block in a Group block. (Place the Image block last.)
  2. It can be confirmed that the "Add Block" button is not displayed when editing the inner blocks.

Screenshots, screen recording, code snippet

In 5.8, you will see an "Add Block" button at the end in the group block, as shown in the following image.

スクリーンショット 2022-01-13 16 04 32


However, it does not show up in 5.9.

スクリーンショット 2022-01-13 16 04 45

To add a new block below the image block, we need to learn a shortcut.

Environment info

  • WordPress 5.9-RC2
  • Twenty Twenty One
  • Mac OS 12.0.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Mamaduka Mamaduka added [Block] Group Affects the Group Block Needs Testing Needs further testing to be confirmed. labels Jan 13, 2022
@kmadhak
Copy link

kmadhak commented Mar 31, 2022

Hello @ddryo , @Mamaduka

Greetings of the day!!!

I have tried to reproduce the same issue, if we select a group then it is showing an option to add a new block, it is working fine.

following are the version details
WordPress:- 5.9.2
Mac OS:-12.2.1
Chrome:- 99.0.4844.84
Theme: Twenty Twenty One and Twenty Twenty Two

Please review from your end and let me know if there is anything.

Thank you.

@ddryo
Copy link
Contributor Author

ddryo commented May 18, 2022

@kmadhak

Yes, the inserter appears when the Group Block itself is selected.

However, I am pointing out the behavior while selecting a "Child Blocks" in a Group.

It is very inconvenient now that the inserter will not show up unless the parent Group Block is selected, which is much more inconvenient than before.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Aug 25, 2022
@mrfoxtalbot
Copy link

I can confirm that in Version 14.0.3, the "+" (add block) is still only available when the group block is selected, as @ddryo described.

Screen.Capture.on.2022-09-13.at.08-09-51.mov

I am curious as to wether this was a deliberate decision or just a side effect of some other change. Any thoughts @Mamaduka? Thank you!

@mrfoxtalbot mrfoxtalbot added [Type] Regression Related to a regression in the latest release and removed Needs Testing Needs further testing to be confirmed. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. labels Sep 13, 2022
@Mamaduka
Copy link
Member

Hi, @mrfoxtalbot

I believe this is intentional. The change was introduced in #36656.

@mrfoxtalbot mrfoxtalbot removed the [Type] Regression Related to a regression in the latest release label Sep 13, 2022
@mrfoxtalbot
Copy link

Thank you for the context, @Mamaduka.

If this is indeed intended, I think I am going to close this issue as "wont fix" to avoid duplication and contain the number of issues open. If you feel this merits a further conversation or a different approach, it might be a good idea to comment on #36656 @ddryo.

Thank you!

@mrfoxtalbot mrfoxtalbot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block
Projects
None yet
Development

No branches or pull requests

4 participants