Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordPress 5.9 Beta 1 – UI issue with Clear button on Duotone Settings #37087

Closed
monika-12 opened this issue Dec 3, 2021 · 4 comments
Closed

WordPress 5.9 Beta 1 – UI issue with Clear button on Duotone Settings #37087

monika-12 opened this issue Dec 3, 2021 · 4 comments
Labels
[Feature] Colors Color management Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
WordPress 5.9 Must-Haves

Comments

@monika-12
Copy link

Description

Clear button on Duotone settings overlaps with Focus Border and looks bad in the user interface.

Step-by-step reproduction instructions

  • Click on Duotone Settings
  • Double click on Highlights option
  • Focus Border on Highlight option will overlap with Clear button

Screenshots, screen recording, code snippet

https://share.getcloudapp.com/z8u1jxrB

Environment info

  • macOS Big Sur V-11.6
  • Browser: Google Chrome
  • Local Environment: Local by Flywheel
  • WordPress Version: development version (5.9-beta1)

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@annezazu
Copy link
Contributor

annezazu commented Dec 3, 2021

I can replicate this with beta 1:

Screen Shot 2021-12-03 at 11 03 44 AM

cc @ajlende :)

@annezazu annezazu added this to 📥 To do in WordPress 5.9 Must-Haves via automation Dec 3, 2021
@annezazu annezazu added [Feature] Colors Color management [Type] Enhancement A suggestion for improvement. labels Dec 3, 2021
@ajlende ajlende added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Dec 3, 2021
@amustaque97
Copy link
Member

Hi, I would ❤️ to take this up 😄

@amustaque97
Copy link
Member

After investigation, I found that, fix is already merged into trunk branch 3 days ago. Running latest code doesn't show this behavior.

Screenshot:
image

I believe we can close this issue. :)

@ajlende
Copy link
Contributor

ajlende commented Dec 5, 2021

Resolved by #37016

@ajlende ajlende closed this as completed Dec 5, 2021
WordPress 5.9 Must-Haves automation moved this from 📥 To do to ✅ Done Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Colors Color management Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
No open projects
WordPress 5.9 Must-Haves
✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ajlende @monika-12 @amustaque97 @annezazu