Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter stays fixed on the screen when scrolling #36882

Closed
simison opened this issue Nov 25, 2021 · 3 comments · Fixed by #36798
Closed

Inserter stays fixed on the screen when scrolling #36882

simison opened this issue Nov 25, 2021 · 3 comments · Fixed by #36798
Labels
[Type] Bug An existing feature does not function as intended

Comments

@simison
Copy link
Member

simison commented Nov 25, 2021

Description

When scrolling on the page and I hover to reveal an inserter, the inserter becomes fixed while I would expect it to scroll with the rest of the content.

It just feels jumpy when it doesn't stick to the place:

Screen.Recording.2021-11-25.at.19.15.36.mov
Screen.Recording.2021-11-25.at.19.34.18.mov

FYI @jasmussen perhaps this started after making the appender fixed in #36605 ?

Step-by-step reproduction instructions

  • Go to site editor
  • Reveal inserter by mouse hover and scroll with mouse scroll wheel

Screenshots, screen recording, code snippet

No response

Environment info

  • Gutenberg v12.0.1
  • Firefox 94 MacOS

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

@simison simison added the [Type] Bug An existing feature does not function as intended label Nov 25, 2021
@jasmussen
Copy link
Contributor

Thanks for the ping and the report. It is to an extent the same issue as #35536, which is crucially important for us to fix, and in the 5.9 list. The good news is, @ramonjd created a PR today that in my latest testing appears to fix this really well.

@simison
Copy link
Member Author

simison commented Jan 20, 2022

@ramonjd is this fixed and can be closed?

@ramonjd
Copy link
Member

ramonjd commented Jan 20, 2022

is this fixed and can be closed?

Thanks for the ping. Yes, will close 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants