Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Create consistency between Template and Templates Part - "Add New" modal/dropdown. #36741

Open
paaljoachim opened this issue Nov 22, 2021 · 5 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

I tested the Gutenberg PR build. https://make.wordpress.org/design/2021/03/03/testing-a-gutenberg-pull-request-pr/ for this PR: #36592

Templates screen
Clicking Add New I see this:

Screenshot 2021-11-22 at 17 02 22

I am able to add a new template for "Front Page", "Archive" and "Search" but not a custom/general template.
Are there plans to extend?

--

Template Parts screen
Clicking Add New I see this:

Screenshot 2021-11-22 at 17 05 59

I am able to add a new template part: "General", "Header" and "Footer".
A template part can also be a sidebar. So I assume we can use the General for such use.

Or perhaps there should be a custom option in Templates and Template Parts.

--

The above approaches should use the same method, but we see two different methods when clicking "Add New"
Templates open as a drop down. While Template Parts (parts?) open as a modal.

Should we go with one or the other approach (Modal or drop down) in the Templates and Templates Parts screen, so that we have a consistency when clicking the "Add New" button?

This can be looked at later on.

@annezazu
Copy link
Contributor

I am able to add a new template for "Front Page", "Archive" and "Search" but not a custom/general template.
Are there plans to extend?

+1 to this question. I originally had the call for testing setup to add a custom/general template but now see this isn't an option. Going to have folks select Archive to move the task along but ideally would like them to create a custom template.

cc @kevin940726

@paaljoachim
Copy link
Contributor Author

Hey Anne

I added a separate issue for adding a new custom/general template.

@kevin940726
Copy link
Member

kevin940726 commented Nov 30, 2021

Creating a template part opens a modal because it needs a title to enter, while the template doesn't. We could still unify them into a similar UI though. @jameskoster WDYT?

@kevin940726 kevin940726 added the Needs Design Needs design efforts. label Nov 30, 2021
@jameskoster
Copy link
Contributor

I think it's worth exploring some unification (and general tidy-up – the popover is a little strange). I wouldn't say this is high priority for 5.9 though.

@paaljoachim
Copy link
Contributor Author

It is a pretty noticeable UI issue. Because of the contrast between the two methods. It would be nice to get a consistency in place for 5.9 in adding a new Template and Template Part. I would call it a medium priority.

@annezazu annezazu added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Feature] Full Site Editing labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants