Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the navigationMenuId property to id in the Navigation block #36722

Closed
getdave opened this issue Nov 22, 2021 · 2 comments
Closed

Rename the navigationMenuId property to id in the Navigation block #36722

getdave opened this issue Nov 22, 2021 · 2 comments
Assignees
@vcanales
Labels
[Block] Navigation Affects the Navigation Block
Projects
Navigation block WordPress 5.9 Must-Haves

Comments

@getdave
Copy link
Contributor

getdave commented Nov 22, 2021

What problem does this address?

The attribute navigationMenuId is overly verbose.

What is your proposed solution?

Simplify to menuId or simply id.
@getdave getdave added the [Block] Navigation Affects the Navigation Block label Nov 22, 2021
@getdave getdave added this to 📥 To do in Navigation block via automation Nov 22, 2021
@getdave getdave added this to 📥 To do in WordPress 5.9 Must-Haves via automation Nov 22, 2021
This was referenced Nov 22, 2021
Closed
Closed
@mtias
Copy link
Member

mtias commented Nov 22, 2021

Also worth considering reusable blocks are using "ref":123. Might be ok to align there.

@vcanales vcanales self-assigned this Nov 22, 2021
@adamziel adamziel mentioned this issue Nov 22, 2021
Merged
@noisysocks noisysocks mentioned this issue Nov 23, 2021
Closed
45 tasks
@priethor priethor changed the title Rename the navigationMenuId property to id in the Navigaiton block Rename the navigationMenuId property to id in the Navigation block Nov 23, 2021
@Mamaduka
Copy link
Member

This issue got fixed via #36739.

Navigation block automation moved this from 📥 To do to ✅ Done Nov 25, 2021
WordPress 5.9 Must-Haves automation moved this from 📥 To do to ✅ Done Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vcanales vcanales

Labels
[Block] Navigation Affects the Navigation Block
Projects
Navigation block
✅ Done
WordPress 5.9 Must-Haves
✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Mamaduka @getdave @mtias @vcanales