Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the inserter in pattern previews #36625

Closed
kjellr opened this issue Nov 18, 2021 · 1 comment · Fixed by #36626
Closed

Hide the inserter in pattern previews #36625

kjellr opened this issue Nov 18, 2021 · 1 comment · Fixed by #36626
Assignees
@jasmussen
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented Nov 18, 2021

Currently, if a block pattern includes an empty column, it displays a giant inserter button in the editor:

Screen Shot 2021-11-18 at 1 13 14 PM

This button also appears in the pattern preview:

Screen Shot 2021-11-18 at 1 11 40 PM

It generally makes sense to show this inserter in the editor, but it definitely doesn't make much sense to show it in the pattern preview. It only exists to show you that you can insert a block there, but you're not going to be inserting blocks directly within the pattern preview.

Can we hide this inserter from the block pattern previews?
@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Nov 18, 2021
@kjellr
Copy link
Contributor Author

kjellr commented Nov 18, 2021

Possibly related to #26404.

@jasmussen jasmussen mentioned this issue Nov 18, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 18, 2021
@Rockstar907 Rockstar907 mentioned this issue Nov 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try: Hide the columns inserter in pattern previews. WordPress/gutenberg
2 participants
@kjellr @jasmussen