Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Template Parts" list with area-based alternative #36613

Closed
jameskoster opened this issue Nov 18, 2021 · 8 comments
Closed

Replace "Template Parts" list with area-based alternative #36613

jameskoster opened this issue Nov 18, 2021 · 8 comments
Labels
[Block] Template Part Affects the Template Parts Block Needs Dev Ready for, and needs developer efforts

Comments

@jameskoster
Copy link
Contributor

Part of #36597

The Template Parts list works well:

Screenshot 2021-11-18 at 12 17 20

However, "Template Parts" is a fairly technical term that we arguably shouldn't be surfacing unless absolutely necessary. Since template parts can be associated with specific areas, we might use those to refine the navigation:

Screenshot 2021-11-18 at 12 19 20

The main drawback here is that "general" template parts would only be accessible through templates directly.

cc @kellychoffman

@carolinan
Copy link
Contributor

carolinan commented Nov 19, 2021

I like the simplicity of showing only header and footer, it looks nice.

The problem I see is user created template parts.
"General" is the default area for user created template parts, and I don't think it is obvious that:

  • There is something called an area
  • How to change the area

I think that is why the template part area setting is under the Advanced panel.

If the general template parts are only accessible through templates, how are they deleted? It is not enough to only select and delete the block in place in the editor.
If I create a template part, I need to be able to find it again, so not having it listed is a major drawback, imagine just testing things, and it being added as clutter in the database.

@jameskoster
Copy link
Contributor Author

I suppose we could still have a "Template Parts" menu item, which is where general template parts would live.

Screenshot 2021-11-19 at 09 51 29

(ignore the icons)

@talldan
Copy link
Contributor

talldan commented Nov 24, 2021

(ignore the icons)

The icons look really nice though 😄

@jameskoster
Copy link
Contributor Author

We can try adding the icons too, but I suspect that would involve edits to the underlying component and so might be better handled separately?

@talldan
Copy link
Contributor

talldan commented Nov 26, 2021

Here's a PR that tackles adding the icons - #36893

@jameskoster jameskoster added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Nov 29, 2021
@ribaricplusplus
Copy link
Member

Should this still be done or should it be closed? I see that the main tracking issue #36597 is closed.

@jameskoster
Copy link
Contributor Author

I think there's a decent argument for this change, if it's simple enough to implement. Not a strong opinion though, because it's unclear if this particular UI will persist in the long term (see #39885).

@annezazu
Copy link
Contributor

annezazu commented Jul 4, 2023

Closing this out as the interface has evolved immensely, including a "Patterns" section with template parts listed. What remains for consideration is this issue around emphasizing header/footer more: #50958

@annezazu annezazu closed this as completed Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

No branches or pull requests

5 participants