Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery block: Image size select doesn't load if no image ids #36554

Closed
glendaviesnz opened this issue Nov 17, 2021 · 16 comments · Fixed by #36806
Closed

Gallery block: Image size select doesn't load if no image ids #36554

glendaviesnz opened this issue Nov 17, 2021 · 16 comments · Fixed by #36806
Assignees
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@glendaviesnz
Copy link
Contributor

Description

If a gallery consists only of external images, which have no WordPress id, then the Image size select in the settings panel gets stuck on loading.

Step-by-step reproduction instructions

  • Add a v2 Gallery block (use Gutenberg > 11.9) with a couple of images
  • Replace the images using the 'Replace' button in the block toolbar and enter an external image url
  • Notice that the Image size selector gets stuck on loading

Screenshots, screen recording, code snippet

Screen Shot 2021-11-17 at 3 42 53 PM

Environment info

Gutenberg > 11.9

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@glendaviesnz glendaviesnz added the [Type] Bug An existing feature does not function as intended label Nov 17, 2021
@Mamaduka Mamaduka added the [Block] Gallery Affects the Gallery Block - used to display groups of images label Nov 17, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 24, 2021
@andrewserong
Copy link
Contributor

I believe I have a fix for this in #36806 (for one of the cases, which was after migrating the v1 gallery using the Update button, there's also a fix in #36804 which should help with testing).

@andrewserong andrewserong moved this from Backlog to In progress in Gallery block improvements Nov 24, 2021
@glendaviesnz glendaviesnz moved this from In progress to Done in Gallery block improvements Jan 17, 2022
@dynamek
Copy link

dynamek commented Jun 13, 2022

I am getting this problem still with latest all updates done. Adding new gallery block (of over 100 images) and the 'Image size' just keeps rotating the 'Loading options…'.

@glendaviesnz
Copy link
Contributor Author

I am getting this problem still with latest all updates done. Adding new gallery block (of over 100 images) and the 'Image size' just keeps rotating the 'Loading options…'.

@dynamek can you please clarify if "with latest all updates done" is just WordPress 6.0, or do you also have the latest Gutenberg plugin installed?

@dynamek
Copy link

dynamek commented Jun 13, 2022

With Wordpress 6.0, and no additional gallery/gutenberg plugin installed.

@glendaviesnz
Copy link
Contributor Author

glendaviesnz commented Jun 13, 2022

With Wordpress 6.0, and no additional gallery/gutenberg plugin installed.

Thanks for confirming. I wasn't able to replicate the issue on a fresh WP 6.0 install with a gallery of several hundred images. Do you see any errors in the browser javascript console, or are there any network requests pending in the developer tools network tab when you see the stuck loading options message?

@dynamek
Copy link

dynamek commented Jun 14, 2022

Looks to be this error

Failed to load resource: the server responded with a status of 502 ()
/wp-json/wp/v2/media…=100&_locale=user:1

@glendaviesnz
Copy link
Contributor Author

Failed to load resource: the server responded with a status of 502 ()
/wp-json/wp/v2/media…=100&_locale=user:1

Do you have access to your server error logs? The error log may provide some more details as to why the error is being thrown.

@dynamek
Copy link

dynamek commented Jun 17, 2022

I sent you the error logs yesterday, have you seen them?

@glendaviesnz
Copy link
Contributor Author

I sent you the error logs yesterday, have you seen them?

No sorry - how did you send them?

@dynamek
Copy link

dynamek commented Jun 19, 2022

I replied by email as it says 'Reply to this email directly'

@dynamek
Copy link

dynamek commented Jun 19, 2022

2022-06-19 22:47:40 Error 147.147.192.4 500 GET /wp-json/wp/v2/media?context=edit&include=55608%2C55609%2C55610%2C55611%2C55612%2C55613%2C55614%2C55615%2C55616%2C55617%2C55618%2C55619%2C55620%2C55621%2C55622%2C55623%2C55624%2C55625%2C55626%2C55627%2C55629%2C55630%2C55631%2C55632%2C55633%2C55634%2C55635%2C55636%2C55637%2C55638%2C55639%2C55640%2C55641%2C55642%2C55643%2C55644%2C55645%2C55646%2C55647%2C55648%2C55649%2C55662%2C55663%2C55664%2C55665%2C55666%2C55667%2C55668%2C55669%2C55670%2C55671%2C55672%2C55673%2C55674%2C55675%2C55676%2C55677%2C55678%2C55679%2C55680%2C55681%2C55682%2C55683%2C55685%2C55695%2C55696%2C55697%2C55698%2C55689%2C55701%2C55702%2C55703%2C55720%2C55722%2C55737%2C55738%2C55739%2C55740%2C55741%2C55742%2C55743%2C55744%2C55745%2C55746%2C55747%2C55748%2C55749%2C55750%2C55751%2C55752%2C55753%2C55754%2C55755%2C55756%2C55757%2C55758%2C55759%2C55783%2C55782%2C55781%2C55780%2C55779%2C55778%2C55777%2C55776%2C55775%2C55774%2C55773%2C55772%2C55771%2C55770%2C55769%2C55768%2C55767%2C55766%2C55765%2C55764%2C55763%2C55762%2C55761%2C55760%2C55784%2C55797%2C55796%2C55795%2C55794%2C55793%2C55792%2C55791%2C55790%2C55789%2C55788%2C55787%2C55786%2C55785%2C55798%2C55812%2C55811%2C55810%2C55809%2C55808%2C55807%2C55806%2C55805%2C55804%2C55803%2C55802%2C55801%2C55800%2C55799%2C55813%2C55829%2C55828%2C55827%2C55826%2C55825%2C55824%2C55823%2C55822%2C55821%2C55820%2C55819%2C55818%2C55817%2C55816%2C55815%2C55814%2C55830%2C55847%2C55846%2C55845%2C55844%2C55843%2C55842%2C55841%2C55840%2C55839%2C55838%2C55837%2C55836%2C55835%2C55834%2C55833%2C55832%2C55831%2C55848%2C55878%2C55877%2C55876%2C55875%2C55874%2C55873%2C55872%2C55871%2C55870%2C55869%2C55868%2C55867%2C55866%2C55865%2C55864%2C55863%2C55862%2C55861%2C55860%2C55859%2C55858%2C55857%2C55856%2C55855%2C55854%2C55853%2C55852%2C55851%2C55850%2C55849%2C55879%2C55909%2C55908%2C55907%2C55906%2C55905%2C55904%2C55903%2C55902%2C55901%2C55900%2C55899%2C55898%2C55897%2C55896%2C55895%2C55894%2C55893%2C55892%2C55891%2C55890%2C55889%2C55888%2C55887%2C55886%2C55885%2C55884%2C55883%2C55882%2C55881%2C55880&per_page=100&_locale=user HTTP/1.0     105 K Apache SSL/TLS access
2022-06-19 22:47:45 Warning 147.147.192.4   (104)Connection reset by peer: mod_fcgid: ap_pass_brigade failed in handle_request_ipc function, referer: https://dev.lalachoirs.co.uk/wp-admin/post.php?post=62085&action=edit       Apache error
2022-06-19 22:47:45 Error 147.147.192.4   7952#0: *1099952 upstream sent too big header while reading response header from upstream nginx error

@glendaviesnz
Copy link
Contributor Author

glendaviesnz commented Jun 20, 2022

Thanks @dynamek, unfortunately that log doesn't give much extra detail. Do you have access to a php error log on your server?

@dynamek
Copy link

dynamek commented Jun 20, 2022

I can't see any problem in the debug.log. I'm happy to give you admin access to see it for yourself.

@glendaviesnz
Copy link
Contributor Author

@dynamek I have opened a new issue for this problem here.

@dynamek
Copy link

dynamek commented Oct 11, 2022 via email

@dynamek
Copy link

dynamek commented Dec 19, 2022

I am having this problem again with a new gallery block today. A difference though with this one is that none of the images are able to open in lightbox. The gallery has 160 photos in it.
I have recently updated PHP to 8.1.13 but the additional directives I was advised to add are still in place.
FcgidBusyTimeout 2400
FcgidIOTimeout 2400
LimitRequestLine 16380
LimitRequestFieldSize 16380

Is someone working to fix this in the core Wordpress files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Development

Successfully merging a pull request may close this issue.

4 participants