Tracking: ToolsPanel Follow Ups

[aaronrobertshaw]

This issue aims to assist in tracking the required follow-ups resulting from the recent merge of the new ToolsPanel component and dimensions panel updates.

Tasks

Blocks

• Cover: Move cover min-height into dimensions panel via SlotFill #34065
• Group Block: Add support for margin control to the group block #33909

Block Supports

Before the new supports proposed in #28356 were to be added, it was desired to have a means of progressive disclosure for the Dimensions panel. With the ToolsPanel now in place and providing this, the following block supports can be picked up.

• Block Support: Add height block support feature #32499
• Block Support: Add min-height block support #33970
• Block Support: Add width block support feature #32502

Updating Block Support Panels

Now the ToolsPanel has landed we can switch all the block support panels over to using this component. This will hopefully allow greater adoption of block supports while reducing the prominence of those supports' UI when it's not required.

Once all block supports have been switched over to the ToolsPanel, ordering these as per #35541 will only be a matter of reordering the InspectorControls slots accordingly.

• Switch typography block support to use ToolsPanel
  • Typography: Switch to ToolsPanel for block support UI #33744
  • ToolsPanel: Update typography panel layout #35911
• Switch border block support to use ToolsPanel
  • Borders: Switch to ToolsPanel for displaying UI #33743
  • Border panel: Update panel layout #35938
• Switch colors block support to use ToolsPanel
  • Color Block Support: Switch to ToolsPanel for displaying UI #34027

Determining Default Controls

Different blocks will need different block support controls exposed by default.

For each block support toolset, find all the blocks that opt into that support and determine which if any controls should be shown by default. Each block's block.json file could be updated in separate PRs for more focused discussion or as a batch if this first pass on controls is rather superficial.

• Dimensions panel defaults
  • Dimensions Panel: add padding tool as default for blocks where this is common setting #34026
  • Margin block supports: show by default in site title and site tagline #34060
• Border panel defaults
  • Border controls: add defaults in the ToolPanel #34061
• Color panel defaults
  • Block Support: Update color panel default controls #38511
• Typography panel defaults
  • Typography block support: add typography support and defaults #34064
  • Post Comments Form: ensure typography styles are applied to child elements #36188

ToolsPanel UI

• ToolsPanel: switch to plus icon when no controls present in panel body #34107
• ToolsPanel: change icon from horizontal to vertical ellipsis #34369
• ToolsPanel: Refine component behaviour #34530
• Audit and improve ToolsPanel's a11y (semantics, focus management, announcing changes to screen reader users)
  • Color design tools - accessibility issues #40460

Miscellaneous

• ToolsPanel component: refactor to typescript #34028
• Dimensions Support: Add SlotFill to Dimensions Panel #34063
• ToolsPanel: Use Grid component to handle layout #35621
• ToolsPanel: Improve unit tests #35658
• ToolsPanel: Remove hardcoded classnames #35415
• ToolsPanelItem: Add panelId check before calling toggle methods #35375
• InspectorControls: Wrap block support slots in ToolsPanel #34157

Future Follow-Ups

• [WIP] Button: Adopt width block support for button widths #32878
• Possibly exposing underlying Grid component in ToolsPanel for more flexibility and control of panel layout

[adamziel]

@aaronrobertshaw @apeatling Is there any feature that you think could still land until Wednesday next week to be included in WordPress 6.0 release? To increase visibility, we can add it to the WordPress Editor 6.0 project board.

[apeatling]

I think all the follow up work in terms of this issue is done for this cycle. Height/min-height/width and future issues can be refreshed and looked at down the line in a new issue.