Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Comments Pagination Previous block #35009

Closed
SantosGuillamot opened this issue Sep 21, 2021 · 2 comments · Fixed by #36912
Closed

Post Comments Pagination Previous block #35009

SantosGuillamot opened this issue Sep 21, 2021 · 2 comments · Fixed by #36912
Assignees
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks Needs Design Needs design efforts. New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress

Comments

@SantosGuillamot
Copy link
Contributor

Description

Displays the previous comments page link. This should be similar to the Query Pagination Previous block.

This block is part of the Post Comments Loop block, for more context please visit this Tracking Issue or its GitHub project.

Potential Settings

Requirements

References

This should be similar to the Query Pagination Previous block.

@SantosGuillamot SantosGuillamot added [Feature] Blocks Overall functionality of blocks New Block Suggestion for a new block [Feature] Full Site Editing [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop labels Sep 21, 2021
@SantosGuillamot SantosGuillamot added this to To do in Comments Loop block via automation Sep 21, 2021
@luisherranz luisherranz added the Needs Design Needs design efforts. label Sep 23, 2021
@karmatosed
Copy link
Member

I noticed this has the label for needs design and I want to help out with theme blocks. Regarding what it should support, a first feature set to me seems to be what is supported by query pagination block:

"color": { "gradients": true, "link": true }, "typography": { "fontSize": true, "lineHeight": true }

I would also probably lean heavily on that for a design pattern, but wanted to check before dove in there what other thoughts might be around this (if any).

@SantosGuillamot
Copy link
Contributor Author

Regarding what it should support, a first feature set to me seems to be what is supported by query pagination block.

I totally agree, replicating the set used by the query pagination block seems fine to me.

I would also probably lean heavily on that for a design pattern.

I agree with this as well 🙂 . I feel that having consistency between different blocks would be helpful for both the developers and the users.

@cbravobernal cbravobernal self-assigned this Nov 11, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 26, 2021
@gziolo gziolo moved this from To do to In progress in Comments Loop block Dec 6, 2021
Comments Loop block automation moved this from In progress to Done Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks Needs Design Needs design efforts. New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants