Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post terms block shows post not found multiple times #34937

Closed
karmatosed opened this issue Sep 17, 2021 · 2 comments
Closed

Post terms block shows post not found multiple times #34937

karmatosed opened this issue Sep 17, 2021 · 2 comments
Labels
[Block] Post Terms Affects the Post Terms Block [Type] Bug An existing feature does not function as intended

Comments

@karmatosed
Copy link
Member

Whilst showing that a term doesn't exist is great information, I am unsure it's good repeating it. For example, you can have the following if you view default TT1:

2021-09-17 at 19 32

My recommendation would be to only show once this message as it seems to not require multiple instances. I think an argument might be able to be had for multiple if there is also other content being shown, but in this case, there isn't, it's only showing those 2. I also might be wrong and there's something else going on here.

@karmatosed karmatosed added [Type] Bug An existing feature does not function as intended [Block] Post Terms Affects the Post Terms Block labels Sep 17, 2021
@carolinan
Copy link
Contributor

I think the title confused me; The post term block does not display the message twice, correct?
But the theme has two post terms blocks, one for the tags and one for the categories.

Inside a loop, it correctly displays "No tags" and so on.

@ntsekouras
Copy link
Contributor

Thanks for reporting @karmatosed! I'm going to close this one as the behavior was expected, as @carolinan explains above, and also it seems it has been resolved here, in the way that we have moved forward with a unification of theme blocks placeholder content.

Feel free to reopen if you think we need to take some alternative approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Terms Affects the Post Terms Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants