Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading Block: Add option to adjust spacing below #34392

Closed
supernovia opened this issue Aug 30, 2021 · 5 comments
Closed

Heading Block: Add option to adjust spacing below #34392

supernovia opened this issue Aug 30, 2021 · 5 comments
Labels
[Block] Heading Affects the Headings Block [Type] Enhancement A suggestion for improvement.

Comments

@supernovia
Copy link

What problem does this address?

With blocks as widgets, users have to add a heading block if they want to keep their widget titles. But depending on the theme, that may result in a heading that has a big space underneath it that can currently only be solved with CSS:
Screen Shot 2021-08-30 at 11 24 31 AM

What is your proposed solution?

Offer an option for adjusting the margins. Obviously this isn't nice looking in Preview, but maybe something like this.
Screen Shot 2021-08-30 at 11 22 23 AM

@bph bph added [Block] Heading Affects the Headings Block [Type] Enhancement A suggestion for improvement. labels Sep 6, 2021
@bph
Copy link
Contributor

bph commented Sep 6, 2021

Is the heading block getting padding/margin support?

@supernovia
Copy link
Author

Is the heading block getting padding/margin support?

I hope it will! It'd resolve this widget title issue people are seeing.

@colorful-tones
Copy link
Member

I believe this may have been resolved recently with Add spacing controls to all heading blocks #35772, but could probably use testing and verification.

@ntsekouras
Copy link
Contributor

@colorful-tones is right and there was a discussion and decision to include only the margin support: #35772 (comment).

In order to see this control though you need to enable it in your theme(https://wordpress.slack.com/archives/C02QB2JS7/p1635329909091600).

@ndiego
Copy link
Member

ndiego commented Aug 21, 2022

The Heading block now supports margin, so I am going to close this issue. I also just opened a PR to add padding support.

@ndiego ndiego closed this as completed Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Heading Affects the Headings Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants