Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockFormatControls and related SlotFills now exist on secondary toolbar. No longer "Top Toolbar" #33619

Closed
JustinSainton opened this issue Jul 22, 2021 · 3 comments
Labels
[Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable

Comments

@JustinSainton
Copy link
Contributor

Description

BlockFormatControls and related SlotFills used to be a part of the Top Toolbar when the "Top Toolbar" toggle was checked. Now, they all exist on a secondary toolbar, not the Top Toolbar. Lots of our publishing clients are finding this to be sub-optimal.

Step-by-step reproduction instructions

I recorded a video showing exactly what I'm talking about. But essentially, you don't need any special theme or plugin to see this. Simply compare the behavior and UI of the toolbars when Top Toolbar is checked. There is now a secondary toolbar.

Expected behaviour

I'd expect these format controls, when the Top Toolbar toggle is flagged, to be a part of the top toolbar, not a secondary one.

Actual behaviour

They exist on a new secondary toolbar.

Screenshots or screen recording (optional)

https://vimeo.com/577847427/147e5f6633

WordPress information

  • WordPress version: WP 5.8
  • Gutenberg version: Not installed
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes

I understand that a lot of work went into normalizing the block controls toolbar (#29247). I think that work is amazing, but tend to agree with my publishing partners that this part of the UI is a regression. Even if a new SlotFill were made available to be a part of the top toolbar, that would be more than sufficient to get us back to where we were for the UI in WP 5.7. Thanks!

@talldan
Copy link
Contributor

talldan commented Jul 22, 2021

@JustinSainton Thanks for reaching out. This change is intentional. The reason is that a lot of block toolbars were found to be overlapping other UI in top toolbar mode, particularly in the site/template editors where there's extra functionality in the top part of the screen, like the template options shown in this screenshot:
Screenshot 2021-07-22 at 11 31 24 am

Interested to hear why you think it's a regression—is it just that it takes up more horizontal space now?

I've personally found that it makes the separation between block specific tools and editor tools clearer (I always found having so many icons on one row made finding the right option a little slower) but granted that's open to interpretation.

I'll leave the issue open for further comment to see where the discussion goes.

@talldan talldan added [Feature] Blocks Overall functionality of blocks [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable General Interface Parts of the UI which don't fall neatly under other labels. labels Jul 22, 2021
@JustinSainton
Copy link
Contributor Author

@talldan Interesting perspective, for sure! I think the template editing point is a valid one, I hadn't considered that.

Most of these folks are probably a year or more away from anything related to FSE or template editing in Gutenberg - so the concern from a publishing perspective is the change/shift in UI and it not being expected.

@Mamaduka
Copy link
Member

I believe this was resolved by #49634, and toolbar updates shipped in WP 6.3.

Screenshot

Screenshot 2023-01-04 at 11 35 42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable
Projects
None yet
Development

No branches or pull requests

3 participants