Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A theme.json from child theme is not merged with the one in parent theme #33512

Closed
overclokk opened this issue Jul 16, 2021 · 5 comments
Closed
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme.

Comments

@overclokk
Copy link

I'm testing the theme.json with a child theme and I see that when the child is active and theme.json is present in both child and parent this will replace the one in the parent theme instead of being merged with it, is it a desired behavior?

My first tought was to have some global settings in parent theme and some little modification in child theme.

@carolinan carolinan added the [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. label Jul 16, 2021
@overclokk
Copy link
Author

I just found this issue #25612 and I think that child themes will have more space in the future of FSE, I'd also like to have grand-chils supported from core, for now grand-childs are possible only with plugin.

@dashkevych
Copy link

It would be great if there was a fallback for theme.json located in the parent theme if the child theme does not have one.

@overclokk
Copy link
Author

@dashkevych yes, this is something similar to this issue #33959 as well.

@iandunn
Copy link
Member

iandunn commented Aug 12, 2021

This seems like a duplicate of #25612, is there anything unique here that I'm missing?

If not, this can be closed.

@overclokk
Copy link
Author

@iandunn maybe yes, for now I close this issue in favor of #25612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme.
Projects
None yet
Development

No branches or pull requests

4 participants