Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: When editing a template part is NOT editing a template part #31098

Closed
Sandstromer opened this issue Apr 22, 2021 · 2 comments
Closed

Comments

@Sandstromer
Copy link

Not sure whether to describe this as a bug, a feature request, or just a general discussion.

The issue is when editing a template and making changes to a template part (e.g. header), or what I think the average user may assume is they are making changes to a template part, the changes are not actually applied to the template part. The changes are actually applied to the template containing said template part.

For example, when the Site Editor first loads, the user is generally presented with the page template.
The user then edits the header template part (change background color, add padding etc.), and would naturally assume they have made the changes to the header site-wide.
In fact the changes are only applied to the template part wrapper in the page template, and not the header template part.

To make changes site-wide to the header, the user has to navigate away from the template, and through 'Theme' > 'Template Parts' > 'Headers' > 'header' to select the header template part.
The issue here is that the template part wrapper is not editable, only the blocks within.

My opinion is that a non-dev user would find this confusing.

Hope I have managed to explain what I mean. If not please ask and I'll attempt to explain my thinking further.

@carolinan
Copy link
Contributor

I believe this is a duplicate of #30732

@Sandstromer
Copy link
Author

Oops! My quick scan was too quick. I'll close this in favor of #30732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants