Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSE] Show Template Part color settings when in isolated mode #30641

Closed
annezazu opened this issue Apr 8, 2021 · 5 comments
Closed

[FSE] Show Template Part color settings when in isolated mode #30641

annezazu opened this issue Apr 8, 2021 · 5 comments
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Navigation Component A navigational waterfall component for hierarchy of items. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Apr 8, 2021

What problem does this address?

Currently, if you are viewing an isolated template part, the usual block settings for that template part aren't viewable. You're not able to select the overall template part either to make specific changes to styling. Considering this is an isolated view, it seems one should actually be able to edit the entire template part even more directly including setting colors. This came up as part of the fourth call for testing for the FSE Outreach Program:

I guess what came to mind for me was – why in the “Template Parts –> Headers –> header” can’t I set a background color for my header there? (This is where I expected to find it as a second time FSE user) Here is a screenshot of my header template: https://snipboard.io/PCOXqB.jpg Related, I found I had to set the background color for my header 3 times, once for the index template (like in your video), once on the page home template (screenshot – https://snipboard.io/2iGhOU.jpg), and once on the page template (screenshot – https://snipboard.io/s69bFW.jpg). I was kind of wondering if I could just set it once in the header template itself, but maybe that’s not how this was designed. I also tried to set the header background color on the index template only, but I think because I had set up a homepage and pages, the header color didn’t show up on the homepage and pages with only the index page having the header background color. Anyway, just wanted to share where my head was at as a user 🙂

Template View

Opening the site editor > opening a specific template > selecting the Header template part

Screen Shot 2021-04-08 at 4 21 54 PM

Isolated Template Part View

Opening the site editor > using the navigation component to navigate to a template part > viewing the template part.

Screen Shot 2021-04-08 at 4 18 33 PM

Note that you're unable to even select the parent template part block while in this view.

What is your proposed solution?

When one navigates to the isolated template part, enable the ability to modify the entire template part rather than just showing the contents of the template part.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Navigation Component A navigational waterfall component for hierarchy of items. [Block] Template Part Affects the Template Parts Block labels Apr 8, 2021
@mtias mtias mentioned this issue Aug 6, 2021
13 tasks
@carolinan
Copy link
Contributor

The styles for the template part are saved in the template that includes the template part.
Only the content inside the template part can be changed with the template part itself.

I wonder if we need to rethink template parts and remove all styling and layout options from them and only let them be a container for the content.

Related: #30732

@kevin940726
Copy link
Member

Agree. I don't think this is possible with the current architecture. We could perhaps solve this only for the template part focus mode though (when there's a back button), but I'm not sure if it's worth the effort.

@noisysocks
Copy link
Member

I agree. These settings are stored in the template, it doesn't really make sense for the template part editor to have them. Is there another way of addressing the confusion here? What do you think @mtias?

@jameskoster
Copy link
Contributor

We removed the ability to apply style to Template Part blocks directly in #36571. This should eliminate the confusion around being able to style them in the regular editor, but not in focus mode (and the relationship thereof).

Do you think we can close this issue @annezazu?

To be clear, it should still be possible to edit template part properties like name and area in focus mode (#37220).

@annezazu
Copy link
Contributor Author

Yes :) Thanks for following up here. If this gets added back, we can revisit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Navigation Component A navigational waterfall component for hierarchy of items. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants