Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plain quote style (indent) #28524

Closed
mtias opened this issue Jan 27, 2021 · 8 comments
Closed

Plain quote style (indent) #28524

mtias opened this issue Jan 27, 2021 · 8 comments
Labels
[Block] Quote Affects the Quote Block Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts

Comments

@mtias
Copy link
Member

mtias commented Jan 27, 2021

There's been a few request in the past for the ability to block-indent text. This is generally used in quote heavy contexts (academic contexts, essays, etc). Traditionally the styling for these quotes has been just a margin on a paragraph. This is not great since it sacrifices semantics for visual styling.

What I think we can provide instead is a new block style for Quote called "Plain" that removes the default border and only indents the text while preserving the blockquote element.

image

Thoughts?

@mtias mtias added Needs Design Feedback Needs general design feedback. [Block] Quote Affects the Quote Block labels Jan 27, 2021
@aristath
Copy link
Member

It makes perfect sense... Indenting text without the semantics of a quote is less than ideal. A "plain/indented" style for quotes would work nicely 👍

@paaljoachim
Copy link
Contributor

paaljoachim commented Feb 9, 2021

Here is another indent issue:
No ability to indent
#14554

Another thought as we are right now holding a design triage. Can we add a style to the Paragraph block?
Where indent would be a style to choose from. As it feels like the most natural place to indent would be in a Paragraph block.

@mtias
Copy link
Member Author

mtias commented Feb 9, 2021

@paaljoachim that's the thing we want to avoid, because the indent would carry no semantic meaning there and would degrade the document a bit.

@paaljoachim
Copy link
Contributor

paaljoachim commented Feb 11, 2021

It was brought up during a design triage. Here are some of the comments:

@paaljoachim
I would say that @matias suggestion above is a good one, and can be very helpful.
It would be a "simple" way to create a paragraph that needs to be indented. One just switches it over to a quote block and changes the style. One might expect to be able to indent in the paragraph block though.

@hedgefield
True, although it feels like a workaround. There was discussion before about not being able to indent in general I believe?
--> Older Indent issue: #14554

@hedgefield
And that classic could etc
It'll probably take longer to fix the entire problem, but at least maybe connect those two issues so the bigger effort isn't ignored in case we do this quick fix

@kellychoffman
it might be a step in the right direction, but i don’t think most people will look for quote when they want to indent.
I do think it’s worth doing, just not as the only way to fix the problem.

@paaljoachim paaljoachim added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Feb 12, 2021
@paaljoachim
Copy link
Contributor

paaljoachim commented Feb 12, 2021

As we discussed this issue during a design triage. We agreed it was a good idea to get implemented.
As adding a style seems like a good simple approach that can be done fairly quickly.
Then at a later time figure out an even better way of handling this issue.

I removed the "Needs Design Feedback" label and added a "Needs Dev" and a "Good First Issue" label.

@paaljoachim paaljoachim added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Feb 12, 2021
@danyork
Copy link

danyork commented Oct 12, 2021

Hi all! Just curious about the status of this - any estimate on when this might be available? I see there is pull request #29856 but that is now flagged as stale. I had a case today where we wanted to indent four paragraphs in a blog post and the regular blockquote was not appropriate. And, it turned out we haven't styled the Classic block appropriately so I couldn't use that workaround.

@mtias
Copy link
Member Author

mtias commented Oct 13, 2021

It's a simple patch that just needs a nudge along the way :)

@mkaz
Copy link
Member

mkaz commented Oct 16, 2021

Closed in #29856

@mkaz mkaz closed this as completed Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Quote Affects the Quote Block Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

No branches or pull requests

5 participants