From baa30505e7e7c6c002240de2242b08bf30657f4f Mon Sep 17 00:00:00 2001 From: Riad Benguella Date: Fri, 19 Nov 2021 14:01:46 +0100 Subject: [PATCH] Only render the site editor canvas when the global styles are ready. (#36643) --- lib/full-site-editing/edit-site-page.php | 2 +- .../src/components/global-styles/global-styles-provider.js | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/full-site-editing/edit-site-page.php b/lib/full-site-editing/edit-site-page.php index 2b6946f1baa9b..4cb534ca0c7b8 100644 --- a/lib/full-site-editing/edit-site-page.php +++ b/lib/full-site-editing/edit-site-page.php @@ -183,7 +183,7 @@ function gutenberg_edit_site_init( $hook ) { '/wp/v2/themes?context=edit&status=active', '/wp/v2/global-styles/' . $active_global_styles_id . '?context=edit', '/wp/v2/global-styles/' . $active_global_styles_id, - '/wp/v2/themes/' . $active_theme . '/global-styles', + '/wp/v2/global-styles/themes/' . $active_theme, ) ), 'initializer_name' => 'initializeEditor', diff --git a/packages/edit-site/src/components/global-styles/global-styles-provider.js b/packages/edit-site/src/components/global-styles/global-styles-provider.js index c9c14c36a7d94..f18eff6c728be 100644 --- a/packages/edit-site/src/components/global-styles/global-styles-provider.js +++ b/packages/edit-site/src/components/global-styles/global-styles-provider.js @@ -135,7 +135,7 @@ function useGlobalStylesBaseConfig() { ).__experimentalGetCurrentThemeBaseGlobalStyles(); }, [] ); - return baseConfig; + return [ !! baseConfig, baseConfig ]; } function useGlobalStylesContext() { @@ -144,7 +144,7 @@ function useGlobalStylesContext() { userConfig, setUserConfig, ] = useGlobalStylesUserConfig(); - const baseConfig = useGlobalStylesBaseConfig(); + const [ isBaseConfigReady, baseConfig ] = useGlobalStylesBaseConfig(); const mergedConfig = useMemo( () => { if ( ! baseConfig || ! userConfig ) { return {}; @@ -153,7 +153,7 @@ function useGlobalStylesContext() { }, [ userConfig, baseConfig ] ); const context = useMemo( () => { return { - isReady: isUserConfigReady, + isReady: isUserConfigReady && isBaseConfigReady, user: userConfig, base: baseConfig, merged: mergedConfig, @@ -165,6 +165,7 @@ function useGlobalStylesContext() { baseConfig, setUserConfig, isUserConfigReady, + isBaseConfigReady, ] ); return context;