From 7fcbfdb5da3e33fb29f2f81be9dcc1359abc9da7 Mon Sep 17 00:00:00 2001 From: Marcus Kazmierczak Date: Fri, 8 Oct 2021 08:18:29 -0700 Subject: [PATCH] Page List: Show empty placeholder if no items (#35441) * Add empty response placeholder * Return early if no top level pages * Simplify placeholder to just span and text * Move the check for empty pages up to all_pages This makes it more clear and bails out even earlier. --- packages/block-library/src/page-list/edit.js | 3 +++ packages/block-library/src/page-list/index.php | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/packages/block-library/src/page-list/edit.js b/packages/block-library/src/page-list/edit.js index 2311308c41b16..5328689edcbbe 100644 --- a/packages/block-library/src/page-list/edit.js +++ b/packages/block-library/src/page-list/edit.js @@ -154,6 +154,9 @@ export default function PageListEdit( { ( + { __( 'Page List: No pages to show.' ) } + ) } /> diff --git a/packages/block-library/src/page-list/index.php b/packages/block-library/src/page-list/index.php index 6f99ab14c95ef..dc1a654d757a0 100644 --- a/packages/block-library/src/page-list/index.php +++ b/packages/block-library/src/page-list/index.php @@ -250,6 +250,12 @@ function render_block_core_page_list( $attributes, $content, $block ) { ) ); + // If thare are no pages, there is nothing to show. + // Return early and empty to trigger EmptyResponsePlaceholder. + if ( empty( $all_pages ) ) { + return; + } + $top_level_pages = array(); $pages_with_children = array();