Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load data from readme.txt in the 'Edit metadata' modal #631

Open
matiasbenedetto opened this issue May 13, 2024 · 1 comment · Fixed by #626
Open

Load data from readme.txt in the 'Edit metadata' modal #631

matiasbenedetto opened this issue May 13, 2024 · 1 comment · Fixed by #626
Labels
enhancement New feature or request

Comments

@matiasbenedetto
Copy link
Contributor

What?

Currently, the 'Edit metadata' modal loads only some existing theme data items (such as 'Theme description', 'Author', 'Version', etc.) when you open it. Still, other existing data points coming from readme.txt (such as 'Recommended plugins' and 'Image Credtis') are not loaded, so they can not be edited but only overwritten with new content. Apart from that, it is not clear if you are editing or simply adding new data to the existing one.

Screenshot 2024-05-13 at 10-15-59 Blog Home ‹ Template ‹ WP1 ‹ Editor — WordPress

Expected

Load data from readme.txt in the 'Edit metadata' modal so the theme creators can:

  • Edit the existing data for 'Recommended plugins' and 'Image Credits'.
  • Know the content of the readme.txt file without the need to inspect it in the filesystem as a text file.
@pbking
Copy link
Contributor

pbking commented May 28, 2024

Recommended plugins is loading and saving as expected (I can't recall in which branch it was fixed, but I think it was a side effect of another feature).
Font Credits are being added in this PR (#649)
I think the only thing mentioned that remains is adding Image Credits which is represented in this issue.

Perhaps we could close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

2 participants