Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export creates new patterns by copying content from other patterns, without re-using them #533

Open
madhusudhand opened this issue Mar 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@madhusudhand
Copy link
Contributor

What?

Export or Save changes options creates new patterns and makes the existing patterns orphans.

Steps:

  1. Activate adventurer theme.
  2. Edit home page and add an image block.
  3. Save the template.
  4. Now use one of CBT options "Save changes" or "Export"
  5. Observe the following behavior.

Original template home.html

<!-- wp:group {"style":{"spacing":{"blockGap":"0"}},"backgroundColor":"tertiary","layout":{"type":"default"}} -->
<div class="wp-block-group has-tertiary-background-color has-background">
    <!-- wp:template-part {"slug":"secondary-header"} /-->

    <!-- wp:pattern {"slug":"adventurer/list"} /-->

    <!-- wp:pattern {"slug":"adventurer/search"} /-->

    <!-- wp:template-part {"slug":"footer","tagName":"footer"} /-->
</div>
<!-- /wp:group -->

Template after CBT Export

<!-- wp:pattern {"slug":"adventurer/home"} /-->

newly created home pattern

<?php
/**
 * Title: home
 * Slug: adventurer/home
 * Categories: hidden
 * Inserter: no
 */
?>
<!-- wp:group {"style":{"spacing":{"blockGap":"0"}},"backgroundColor":"tertiary","layout":{"type":"default"}} -->
<div class="wp-block-group has-tertiary-background-color has-background"><!-- wp:template-part {"slug":"secondary-header"} /-->

<!-- wp:group {"metadata":[],"align":"full","style":{"spacing":{"padding":{"top":"var:preset|spacing|80","bottom":"var:preset|spacing|80","right":"var:preset|spacing|50","left":"var:preset|spacing|50"}}},"backgroundColor":"tertiary","layout":{"type":"constrained","contentSize":"1100px"}} -->
<div class="wp-block-group alignfull has-tertiary-background-color has-background" style="padding-top:var(--wp--preset--spacing--80);padding-right:var(--wp--preset--spacing--50);padding-bottom:var(--wp--preset--spacing--80);padding-left:var(--wp--preset--spacing--50)"><!-- wp:heading {"level":3,"style":{"typography":{"textTransform":"uppercase","fontSize":"0.8rem","letterSpacing":"1px"}},"fontFamily":"roboto"} -->
<h3 class="wp-block-heading has-roboto-font-family" style="font-size:0.8rem;letter-spacing:1px;text-transform:uppercase">Browse by Country</h3>
<!-- /wp:heading -->

<!-- wp:heading {"style":{"typography":{"lineHeight":1.1,"fontSize":"80px","textTransform":"uppercase","fontStyle":"normal","fontWeight":"900"}}} -->
<h2 class="wp-block-heading" id="botswana-new-zealand-south-korea-japan-madagascar" style="font-size:80px;font-style:normal;font-weight:900;line-height:1.1;text-transform:uppercase"><a href="">ITALY</a><br><a href="">COSTA RICA</a><br><a href="">CANADA</a><br><a href="">LAOS</a><br><a href="">TURKEY</a></h2>
<!-- /wp:heading -->

<!-- wp:group {"layout":{"type":"constrained"}} -->
<div class="wp-block-group"><!-- wp:image {"id":2350,"sizeSlug":"full","linkDestination":"none"} -->
<figure class="wp-block-image size-full"><img src="<?php echo esc_url( get_stylesheet_directory_uri() ); ?>/assets/images/image.png" alt="" class="wp-image-2350"/></figure>
<!-- /wp:image --></div>
<!-- /wp:group --></div>
<!-- /wp:group -->

<!-- wp:group {"metadata":[],"align":"full","style":{"spacing":{"padding":{"top":"8rem","bottom":"8rem","left":"var:preset|spacing|50","right":"var:preset|spacing|50"}}},"backgroundColor":"primary","layout":{"type":"constrained","contentSize":"1100px"}} -->
<div class="wp-block-group alignfull has-primary-background-color has-background" style="padding-top:8rem;padding-right:var(--wp--preset--spacing--50);padding-bottom:8rem;padding-left:var(--wp--preset--spacing--50)"><!-- wp:columns -->
<div class="wp-block-columns"><!-- wp:column -->
<div class="wp-block-column"><!-- wp:heading {"textAlign":"left","level":3,"style":{"elements":{"link":{"color":{"text":"var:preset|color|background"}}}},"textColor":"background","fontSize":"large"} -->
<h3 class="wp-block-heading has-text-align-left has-background-color has-text-color has-link-color has-large-font-size">Don't find what you're looking for? Search posts here.</h3>
<!-- /wp:heading --></div>
<!-- /wp:column -->

<!-- wp:column -->
<div class="wp-block-column"><!-- wp:search {"label":"Search","showLabel":false,"placeholder":"E.g. \u0026quot;Botswana\u0026quot;","width":538,"widthUnit":"px","buttonText":"Search","style":{"border":{"width":"0px","style":"none","radius":"2px"},"typography":{"letterSpacing":"1px","fontStyle":"normal","fontWeight":"400","fontSize":"0.8rem"}},"backgroundColor":"background","textColor":"primary"} /--></div>
<!-- /wp:column --></div>
<!-- /wp:columns --></div>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer","tagName":"footer"} /--></div>
<!-- /wp:group -->

Note that newly created pattern copies the actual contents from the following patterns leaving them orphans.

<!-- wp:pattern {"slug":"adventurer/list"} /-->
<!-- wp:pattern {"slug":"adventurer/search"} /-->

Expectation

Pattern should reuse the existing patterns.

@skorasaurus
Copy link
Member

skorasaurus commented Apr 11, 2024

also experienced this recently and was wondering what was happening with my theme :D

I am able to reproduce this on 1.3.8 and 2.02.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants