Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require theme names to follow WordPress.org theme directory rules #513

Open
andersnoren opened this issue Feb 8, 2024 · 1 comment

Comments

@andersnoren
Copy link

I like that the plugin checks if the theme name follows the requirements on the WordPress.org theme directory, but I don't think that themes should be required to follow those rules before a clone/child/blank theme can be created.

The reason is that there's no guarantee that the user intends to submit the theme to WordPress.org. He/she could just as easily be using the plugin to create a theme for personal use, or for a client. In that case, there's no need to make sure that the theme name doesn't contain the word "theme", or that the chosen name is available on the directory.

image

(In the image above, there's also no context for why the theme can't contain the word "theme".)

Instead of preventing exports when the theme name breaks the WordPress.org theme directory rules, I'd suggest that the plugin informs the user that he/she won't be able to submit the theme to WordPress.org with the chosen name.

Related: #496. If a "Not for release" checkbox like the one described in that issue is added, the name validation against the theme directory rules could be disabled when the checkbox is checked.

@pbking
Copy link
Contributor

pbking commented Mar 8, 2024

I notice that using the Site Editor tools the names aren't restricted. Which is another bug, as I agree that the user should be warned but not restricted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants