Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Design #111

Open
amitbajracharya opened this issue Aug 15, 2023 · 5 comments
Open

Theme Design #111

amitbajracharya opened this issue Aug 15, 2023 · 5 comments

Comments

@amitbajracharya
Copy link

I am happy to contribute my design for the community. Here is my layout design: https://www.figma.com/file/LLcwwkWgPWpbI7YSfdwmkr/WordPress-FSE---Amit-Bajracharya?type=design&node-id=0%3A1&mode=design&t=syHh96UZKZAxscHF-1

I will work on the inner pages.

@MaggieCabrera
Copy link
Collaborator

Hi @amitbajracharya thank you for contributing your design! It's looking really good!

Just a heads up, since this is a community lead repo, the theme would be developed by contributors (with all of them credited for their work on it) and released under a GPL license. My only suggestion about the design would be to make the text/images as generic as possible. And we probably want to avoid fake numbers/emails on the footer. @kafleg are there any rules in the directory regarding that?

@amitbajracharya
Copy link
Author

@MaggieCabrera Thanks for the input. Yes, we can remove them for sure. Once we finalize the theme name, I can change the text.

@kafleg
Copy link
Member

kafleg commented Aug 17, 2023

Thank you @amitbajracharya
And yes,

  • Use images that are GPL compatible
  • Use other resources like font also GPL compatible
  • Avoid using valid email and phone, instead use, info@example.com

Also, you can also suggest the name of the theme.

@MaggieCabrera
Copy link
Collaborator

MaggieCabrera commented Jan 10, 2024

Sorry @amitbajracharya, I haven't come back to you earlier, but the development of Twenty Twenty-Four had most of my attention. I just checked the figma files and the theme is looking really nice, do you think it's ready for contributors to start working on development?

@MaggieCabrera
Copy link
Collaborator

Also, do you have a name in mind for the theme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants