Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should PEAR.Functions.FunctionCallSignature.Indent be applied on javascript files ? #2441

Closed
naveen17797 opened this issue Apr 3, 2024 · 4 comments

Comments

@naveen17797
Copy link

naveen17797 commented Apr 3, 2024

Bug Description

should PEAR.Functions.FunctionCallSignature.Indent be applied on javascript files ?

This is related to issue #2395, i tried to fix the file with @wordpress/scripts format command, yet it didn't fix this file. So is it right to ignore javascript files from this sniff ?

@jrfnl
Copy link
Member

jrfnl commented Apr 3, 2024

@naveen17797 Javascript support is being removed from PHPCS and by extension from WPCS. Use Javascript specific tooling like eslint/jslint and such instead.

@naveen17797
Copy link
Author

naveen17797 commented Apr 3, 2024

@jrfnl So if i understood correctly, its safe to disable wpcs for all other file extensions except php ? I am using wpcs version 3.0.1

@jrfnl
Copy link
Member

jrfnl commented Apr 3, 2024

@naveen17797 Providing you use tooling like eslint/jslint etc, then, yes, I'd recommend disabling JS scanning via WPCS.

@naveen17797
Copy link
Author

naveen17797 commented Apr 3, 2024 via email

@jrfnl jrfnl closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants