Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CapitalPDangit customizable e.g. for WooCommerce #1945

Closed
kkmuffme opened this issue Aug 15, 2020 · 3 comments
Closed

Make CapitalPDangit customizable e.g. for WooCommerce #1945

kkmuffme opened this issue Aug 15, 2020 · 3 comments

Comments

@kkmuffme
Copy link

Is your feature request related to a problem?

CapitalPDangit is great for ensuring that the WordPress brand is spelled correctly.
It would be amazing if the sniff was customizable, so other brand names, e.g. WooCommerce could be checked too

Describe the solution you'd like

Allow customizing the rule via .xml and add documentation for it to the wiki: https://github.com/WordPress/WordPress-Coding-Standards/wiki/Customizable-sniff-properties

The user provides the correctly spelled word(s), e.g. WooCommerce in the xml, e.g. as a comma separated list or as an array (whatever is preferred by the implementer)

@dingo-d
Copy link
Member

dingo-d commented Dec 20, 2023

To me this would be better suited for something like https://github.com/PHPCSStandards/PHPCSExtra/

@jrfnl
Copy link
Member

jrfnl commented Dec 27, 2023

FYI: I've just closed the issue which was opened in PHPCSExtra. A generic sniff for something like this would be a nightmare to maintain and support, so I'm not interested in having a sniff like that in PHPCSExtra.

On that note: I don't think we should want it in WPCS either.

@dingo-d
Copy link
Member

dingo-d commented Dec 27, 2023

Yeah, it sounds too generic for WPCS in my opinion, that's why I suggested extras. But I can see how difficult it would be to maintain it, so I'll close this issue 👍🏼

@dingo-d dingo-d closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants