Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HelpHub] Gallery block #463

Closed
17 of 19 tasks
femkreations opened this issue Sep 25, 2022 · 18 comments
Closed
17 of 19 tasks

[HelpHub] Gallery block #463

femkreations opened this issue Sep 25, 2022 · 18 comments
Assignees
Labels
6.1 Changes in 6.1 release 6.2 Changes in 6.2 release 6.3 Changes in 6.3 release block editor Gutenberg related issues high priority self-assigned [Status] Done Issue is completed tracking issue Use to track a series of related issues. user documentation (HelpHub) Improvements or additions to end-user documentation

Comments

@femkreations
Copy link
Collaborator

femkreations commented Sep 25, 2022

Article: https://wordpress.org/documentation/article/gallery-block/

Update for 6.3

  • Allow dragging-and-dropping images from the inserter to image blocks. 49673
  • Replace "Image size" with "Resolution" in image size controls. 49112
  • Update Gallery block to use consistent 40px components. 49101
  • Add help text to Gallery Image Size control 49074
  • [Inserter - Media tab]: Upload Openverse images when inserted 48501
  • add block controls on the inspector 49838

Update for 6.2

  • Add toolbar button to add a caption. 47325

Updating for 6.1

  • Add padding and margin support to the gallery block. 43965
  • Display upload error notices using snackbars. 43946
  • Add background color block supports. 43294
  • Opt-in to axial (column/row) block spacing controls 41175
  • Include image caption when converting a classic block gallery. 40872
  • Remove redundant block name from "settings" panels 40275

General

  • Make sure all screenshots are relevant to the latest version
  • Make sure videos, if any, are up to date
  • Add ALT tags for the images
  • Make sure the headings are in sentence case
  • Convert all reusable blocks to a ‘regular block’.
  • Update the changelog at the end of the article

Notes

  1. We are not adding detailed updates for the Block settings - Typography, Color, Layout, Dimension and Border and for the More Options setting in the block toolbar. Pls mention the settings included for the block and link to the detailed settings pages instead.
  2. Some of the PRs have great videos that can be added to the article.
@alianschiavoncini
Copy link

The Add option has been removed in Toolbar.
New screenshot:
gallery-toolbar

The "Add images" paragraph can be removed.

@Thelmachido
Copy link

@femkreations can you please assign this to me, I am working on it.

@Thelmachido
Copy link

Hi @femkreations I believe I have gone throught the list of to-do can you please review?

@mrfoxtalbot
Copy link

I have moved this issue to the "Needs Review" column. Please keep in mind to include this step in your process @Thelmachido.
Thank you!

@mrfoxtalbot
Copy link

mrfoxtalbot commented Apr 1, 2023

I have reviewed the article myself and adjusted a few things, @Thelmachido:

  • Added several missing alt texts
  • Replaced a screenshot the "Cog" icon with the "Sidebar" one and updated the wording.
  • Converted "bold" paragraphs to H4s to give the article a more semantic structure and to provide a better table of contents. Unless there is some reasons I am unaware of (@femkreations?) , I would strongly encourage everyone to use actual headings as much as possible.

We can do a second review if needed, and mark this one as solved.

@femkreations femkreations added 6.3 Changes in 6.3 release good first issue Good for newcomers labels Jul 11, 2023
@Leonardus-Nugraha Leonardus-Nugraha added the tracking issue Use to track a series of related issues. label Jul 25, 2023
@anandau
Copy link
Collaborator

anandau commented Aug 8, 2023

I am interested in working on this. Please assign me.

@anandau
Copy link
Collaborator

anandau commented Sep 6, 2023

Hi @zzap
I couldn't manage to look into this task and will be away from work for the next couple of weeks. You can unassign me from this task for now.

@zzap zzap unassigned anandau Sep 6, 2023
@zzap
Copy link
Member

zzap commented Sep 6, 2023

Done 👍

@zzap zzap added the [Status] To do Issue marked as Todo label Sep 6, 2023
@julia0096
Copy link

/assign

@github-actions
Copy link

Hey @julia0096, thanks for your interest in this issue! 🍪🍪🍪
If you have any questions, do not hesitate to ask them in our #docs Slack channel.
Enjoy and happy contributing ❤️

@julia0096
Copy link

I found couple of differences in the new version, screenshots below with explanations:

Screenshot from 2023-09-14 17-07-54
Adding the Gallery block via + icon looks a bit different.

Screenshot from 2023-09-14 17-16-56
Block Toolbar doesn't have Captions or Add -icons anymore. The Upload / Media Library -buttons have been added below the Toolbar (or at least they don't show in the previous screenshots anywhere).

Screenshot from 2023-09-14 17-29-26
A screenshot of only the Upload / Media Library section in case it's addition need a separate section to the article.

Screenshot from 2023-09-14 17-36-48
A screenshot of only the Toolbar.

Screenshot from 2023-09-14 17-37-25
When you have uploaded some images, the Toolbar expands. Now the Captions icon is there again, with some completely new buttons, from left to right: Apply duotone filter (the black and white triangle), Align, Captions, Insert link, Crop, Replace.

Screenshot from 2023-09-14 17-38-34
Transform to -menus items are in different order.

@attekosonen
Copy link

The styles tab formatting has changed and multiple block settings have been moved from settings tab under styles tab:

Screenshot from 2023-09-14 17-51-54

@attekosonen
Copy link

Advanced settings tab has also changed and now includes "title attribute" and "additional css classes"

Screenshot from 2023-09-14 18-05-19

@attekosonen
Copy link

Under "Border" section there seems to be a spelling error:

"The Galley block provides border settings options to add border color, width, and radius."

Should be:

"The Gallery block provides border settings options to add border color, width, and radius."

@julia0096
Copy link

Screenshot from 2023-09-14 18-06-04
Block Settings: Preview -button has been changed to an icon.

Screenshot from 2023-09-14 18-07-00
Colums-settings have a "Image Size" option now.

Screenshot from 2023-09-14 18-21-55
Border settings have a separate color option now.

@julia0096 julia0096 removed their assignment Sep 14, 2023
@zzap
Copy link
Member

zzap commented Oct 2, 2023

@docs-reviewers, this is ready for /review

@github-actions github-actions bot added [Status] Review Issue in review and removed [Status] To do Issue marked as Todo labels Oct 2, 2023
@zzap zzap added [Status] To do Issue marked as Todo and removed good first issue Good for newcomers [Status] Review Issue in review labels Oct 2, 2023
@Leonardus-Nugraha Leonardus-Nugraha self-assigned this Oct 10, 2023
@github-actions github-actions bot added [Status] In progress Issue is in progress and removed [Status] To do Issue marked as Todo labels Oct 10, 2023
@Leonardus-Nugraha Leonardus-Nugraha added [Status] Review Issue in review and removed [Status] In progress Issue is in progress labels Oct 17, 2023
@github-actions
Copy link

Heads up @docs-reviewers - the "[Status] Review" label was applied to this issue.

@Leonardus-Nugraha
Copy link
Collaborator

Content updated for 6.3. Closing this issue and moving further updates and discussion for 6.4 updates on this issue
Thank you for all your contributions!

@github-actions github-actions bot added [Status] Done Issue is completed and removed [Status] Review Issue in review labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.1 Changes in 6.1 release 6.2 Changes in 6.2 release 6.3 Changes in 6.3 release block editor Gutenberg related issues high priority self-assigned [Status] Done Issue is completed tracking issue Use to track a series of related issues. user documentation (HelpHub) Improvements or additions to end-user documentation
Projects
Status: Done
Status: Done
Development

No branches or pull requests

9 participants