Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HelpHub] Pinterest #247

Closed
2 tasks
femkreations opened this issue Mar 3, 2022 · 9 comments
Closed
2 tasks

[HelpHub] Pinterest #247

femkreations opened this issue Mar 3, 2022 · 9 comments
Assignees
Labels
5.9 Changes in 5.9 release block editor Gutenberg related issues new document Requests for new page/article. user documentation (HelpHub) Improvements or additions to end-user documentation

Comments

@femkreations
Copy link
Collaborator

What is the new page you are requesting?

New article required for the Pinterest block

General

  • make sure all screenshots are relevant for the current version (5.9)
  • update changelog at the end of the article
@femkreations femkreations added the new document Requests for new page/article. label Mar 3, 2022
@zzap zzap added user documentation (HelpHub) Improvements or additions to end-user documentation block editor Gutenberg related issues 5.9 Changes in 5.9 release labels Mar 7, 2022
@femkreations femkreations added this to To do in Block Editor End User Docs Update to 5.9 via automation Mar 7, 2022
@bph
Copy link

bph commented Mar 12, 2022

@rmartinezduque
Copy link

rmartinezduque commented Mar 22, 2022

Hi! I've been recently working on the article for the Pinterest embed block. I followed the structure of similar articles, such as the Twitter or the Flickr embed, and took screenshots of the current version (5.9).

Let me know your thoughts, thank you!

@zzap
Copy link
Member

zzap commented Mar 22, 2022

Hi @rmartinezduque , thank you so much for working on this. Text is great, I just left a comment to remove one sentence. As for screenshots being in Spanish, I made those same ones with English. Here they are:

Pinterest-1
Pinterest-2
Pinterest – bg

Let me know what's your WordPress.org username so I can give you permissions to create new article 🎉

@zzap zzap moved this from In progress to Review in progress in Block Editor End User Docs Update to 5.9 Mar 22, 2022
@rmartinezduque
Copy link

@zzap Thank you for reviewing this so quickly and sending these screenshots! I'll make the changes in the draft now. My WordPress.org username is rmartinezduque. 🙂

@rmartinezduque
Copy link

rmartinezduque commented Mar 23, 2022

@zzap just an update here: I included one more screenshot of an embedded Pinterest profile (I was able to get it in English) at the beginning of the draft as I thought it would be nice to have another example. If for some reason you think it doesn't fit well, please feel free to let me know. Thank you again!

@zzap
Copy link
Member

zzap commented Mar 23, 2022

Thank you @rmartinezduque , it looks good and I'd keep additional screenshot.

I added you as HelpHub editor so you should be able to create new Article. Let me know if you can't.

  1. Go to https://wordpress.org/support/wp-admin/ and create new Article.
  2. Naming convention for embed blocks is {NAME} Embed so this one will be Pinterest Embed.
  3. The slug will automatically be pinterest-embed, check if it is.
  4. Categories: Block Editor and Embed Blocks.
  5. Personas: Publishers.
  6. Add Changelog at the bottom. See here how: https://docs.google.com/document/d/1lzwonGExUo6upqb6q8t_Z8D-jCX4m8uTKCOQ1nAjFb8/edit#bookmark=id.vo89gryzlk1a

Let me know if you need any help. If you are unsure and want another review in dashboard, you can save it as a draft and ask for another look, that's totally OK. If you're happy with the result just hit Publish 🙌

You rock! ⭐

@rmartinezduque
Copy link

rmartinezduque commented Mar 24, 2022

Hi @zzap! Thanks for the detailed instructions. The preview looked to me, so I went ahead and published it: https://wordpress.org/support/article/pinterest-embed/!

If you could double-check in any case that everything is as it's supposed to be, I'd appreciate it! Thank you! 🙌

Edit: I've realized that the Changelog is not being displayed in the Topics table. How can I change that?

@zzap
Copy link
Member

zzap commented Apr 4, 2022

Edit: I've realized that the Changelog is not being displayed in the Topics table. How can I change that?

You can change that by making word Changelog a heading. H2 would be semantically correct. Thanks

@zzap zzap closed this as completed Apr 4, 2022
Block Editor End User Docs Update to 5.9 automation moved this from Review in progress to Done Apr 4, 2022
@rmartinezduque
Copy link

Done, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.9 Changes in 5.9 release block editor Gutenberg related issues new document Requests for new page/article. user documentation (HelpHub) Improvements or additions to end-user documentation
Development

No branches or pull requests

4 participants