Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests from packages (composer) #8

Closed
ibrahimBeladi opened this issue Jan 15, 2020 · 6 comments
Closed

Remove tests from packages (composer) #8

ibrahimBeladi opened this issue Jan 15, 2020 · 6 comments
Labels
enhancement Improve performace or existing feature.

Comments

@ibrahimBeladi
Copy link
Member

Exclude tests from the package when install from composer. And move the dependency management to be from composer and not via downloading.

@ibrahimBeladi ibrahimBeladi changed the title Remove test from packages (composer) Remove tests from packages (composer) Jan 15, 2020
@usernane usernane added the enhancement Improve performace or existing feature. label Jan 29, 2020
@usernane
Copy link
Member

usernane commented Mar 1, 2020

Have been reading about this issue for the last few days. It seems there is no standard way to do it. Some authors of composer suggest the use of .gitattributes but in my opinion it is not the best solution.
I have been reading through https://ithub.com/composer/composer/issues/1750 and composer/composer#4438. According to what I have seen, they say that it is the job of the developer to clean up what he needs and what is not needed.

What do you think @ibrahimBeladi ?

@ibrahimBeladi
Copy link
Member Author

** composer/composer#1750

@ibrahimBeladi
Copy link
Member Author

In my opinion, the output (the package) should not contain any tests and the tests should be done by the maintainer(s). If it is possible to selectively get the tests that would be a bonus. But ideally, I would prefer not to have someone's tests on my machine. I am not sure if there are solutions for this, because is is too old now. But, it would not hurt to try.

@peter279k
Copy link

peter279k commented Mar 5, 2020

I think it can also consider using the .gitattributes to accomplish this issue.

Some related PRs are as follows to be referenced:

usernane added a commit that referenced this issue Mar 6, 2020
Related to issue #8
@usernane
Copy link
Member

usernane commented Mar 6, 2020

For the time being, this will be applied to the framework it self but not the libraries at which it depends on. The thing is that currently, the libraries that the framework depends on are in the folder entity. If composer is used, then every thing will be moved to vendor which is outside the scope of the framework.

The framework has its own mechanism to auto load classes. The implementation can be found in the class AutoLoader The auto-loader of the framework will force you to use object oriented approach. One of the things that I don't like about composer is that it has some code which is not fully object oriented in the auto-loader implementation.

Will consider the ability to load dependent libraries for the future using composer.

@peter279k
Copy link

@usernane, thanks for your reply.

IMHO, I think we can provide two approaches about that you mention.

We can use the composer to load classes automatically or using customized autoloader without composer to load classes.

And it can be convenient for Composer fan to use/enjoy this framework :).

@usernane usernane added this to the Version 1.1.0 milestone Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve performace or existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants