This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
#931 - Previews on CPT #954
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webdevstudios/nextjs-wordpress-starter/AWpSZGyEU6As2ikTrKmTqVrSTXG7 |
gregrickaby
force-pushed
the
hotfix/931-CPT-previews-not-working
branch
from
9041435
to
a7f9e01
Compare
gregrickaby
suggested changes
Mar 2, 2022
| @@ -29,6 +29,7 @@ export default function Archive({ | |||
| taxonomy, | |||
| term | |||
| }) { | |||
| // console.log('ARCHIVE') | |||
There was a problem hiding this comment.
@johnrobertmcc Please remove all the console.log() comments
| @@ -61,7 +61,7 @@ export default async function getPostTypeStaticProps( | |||
| } | |||
| } | |||
|
|
|||
| /* -- Handle dynamic archive display. -- */ | |||
| // /* -- Handle dynamic archive display. -- */ | |||
There was a problem hiding this comment.
@johnrobertmcc Please fix this comment syntax.
…evStudios/nextjs-wordpress-starter into hotfix/931-CPT-previews-not-working
…ter into hotfix/931-CPT-previews-not-working
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #931
Note
This solves the routing problem of previews not being generated, but it does not solve the problem of the 'preview button' being broken. I have opened an issue here.
Description
CPT Previews were not viewable due to missing logic in building the Apollo Query.
Verification
How will a stakeholder test this?
git checkout hotfix/931-CPT-previews-not-workingCreate new CPT in WP Admin
In CPT Ui, ensure
show in GraphQLis set to true for new CPT.Click on preview of CPT, it should redirect to
/preview/${databaseId}/with a working preview.NOTE: As mentieond above, the 'preview in new tab' button does not work on CPT, it will redirect to home page. Please use 'preview' button in quick edit on pagination of CPT.
Ensure regular post type previews are working as well.