Skip to content

Latest commit

 

History

History
101 lines (68 loc) · 4.13 KB

CONTRIBUTING.md

File metadata and controls

101 lines (68 loc) · 4.13 KB
Raw

Contributing to Vee-Validate

First of all, thanks for taking interest into contributing to this repository, below is what you need to know about the project.

Getting Started

Fork the repository, or clone it:

git clone https://github.com/logaretm/vee-validate.git

Install dependencies using yarn

yarn

Folder Structure

As you can see we have:

  • src contains the working code for the repository:
    • core: contains files that are the
    • rules: contains validation rules that are available to the validator instances.
    • utils: contains commonly used utility functions.
  • dist: contains the unminified and the minified build of the repository.
  • docs: contains the src and built files for the documentation, we use vuepress to generate the docs content.
  • locale: contains the localized messages files.
  • tests: contains the test files for the project, it uses jest for testing. it contains a similar folder structure as the src folder.
  • scripts: has all our custom scripts used to bundle the project, release the docs and localization files generation.

Issues

When creating issues, please provide as much details as possible. A clear explanation on the issue and a reliable production example can help us greatly in improving this project. Your issue may get closed if it cannot be easily reproduced so please provide a working example using either Codesandbox or jsfiddle. Your example should only focus on the issue, minimal and clearly produces the issue.

If your issue gets closed for not providing enough info or not responding to the maintainers' comments, do not consider it a hostile action. There are probably other issues that the maintainers are working on and must give priority to issues that are well investigated, you can always revisit the issue and address the reasons that it was closed and we will be happy to re-open it and address it properly. Sometimes a commit will close your issue without a response from the maintainers so make sure you read the issue timeline to prevent any misunderstandings.

Code Style

The code style is enforced with eslint and is checked automatically whenever you commit. Any violation of the code style may prevent merging your contribution so make sure you follow it. And yes we love our semi-colons.

Commit Style

Commit messages are enforced with commitlint which is configured to help you write a suitable commit message, the checks are run automatically when you commit.

Contributing To The Docs

If you want to contribute to the docs you can find it in the docs folder.

Our docs require ./dist/vee-validate.esm as dependency to run successfully in your local machine. You can generate this dependency by executing the following command from the root of the repository:

yarn build:esm
# or
npm run build:esm

And then you can run vuepress local dev server by running:

yarn docs:dev
# or
npm run docs:dev

Pull Requests

  • Make sure you fill the PR template provided.
  • PRs should have titles that are clear as possible.
  • Make sure that your PR is up to date with the branch you are targeting, use git rebase for this.
  • Unfinished/In-Progress PRs should have [WIP] prefix to them, and preferably a checklist for ongoing todos.
  • Make sure to mention which issues are being fixed by the PR so they can be closed properly.
  • Make sure to preview all pending PRs to make sure your work won't conflict with other ongoing pull-request.
  • Coordinate with ongoing conflicting PRs' authors to make it easier to merge both your PRs.

Source Code

Currently we are using ES2015 (ES6) for the source code, using buble and rollup to convert and bundle it to ES5, the available builds are: non-minified and minified and esm build.

Testing

Each test file represents a unit test to the corresponding file in the src folder.

To run the tests:

yarn test
# or
npm run test

Building

Use this command to build all project bundles and localization files:

yarn build
# or
npm run build