Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a more robust way to handle the tar extraction of the downloaded files #160

Open
2 tasks
PaulRBerg opened this issue Sep 13, 2021 · 3 comments
Open
2 tasks
Labels
enhancement Improvement for an existing feature or system

Comments

@PaulRBerg
Copy link
Collaborator

The current way the repo files are extracted after they are downloaded is prone to errors. I've spent four hours today debugging #135, thinking that the issue is related to Jest or GitHub Actions, whereas in fact that was caused by a bug in the getRefs function. Read the comments I left in the issue for more details.

To-dos:

  • Find or build an external package that can handle the parsing of the GitHub ref used to download the repo files from codeload.github.com
  • Make the getRefs function less bloated
@PaulRBerg PaulRBerg added the enhancement Improvement for an existing feature or system label Sep 13, 2021
@PaulRBerg
Copy link
Collaborator Author

@PaulRBerg
Copy link
Collaborator Author

The getRefs must definitely be overhauled such that ref is always the branch name itself, and it is not prefixed with refs/heads. Ditto for tags, remotes, etc.

@Adsgw
Copy link

Adsgw commented Jan 10, 2022

Continuous Integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for an existing feature or system
Projects
None yet
Development

No branches or pull requests

2 participants