Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.7 #63

Merged
merged 24 commits into from Dec 22, 2022
Merged

v0.7 #63

merged 24 commits into from Dec 22, 2022

Conversation

HarryET
Copy link
Contributor

@HarryET HarryET commented Aug 15, 2022 •
edited

Description

This release will bump the versions of dependencies as well as bring the codebase into a modern rust version. Merging this PR is reliant on WalletConnect/hyper-alpn#9 getting merged and released first.

How Has This Been Tested?

Using cargo test

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@HarryET HarryET requested review from arein and sistemd August 15, 2022 13:33
@HarryET HarryET self-assigned this Aug 15, 2022
@HarryET HarryET changed the title feat: v0.7 v0.7 Aug 15, 2022
arein
arein approved these changes Aug 15, 2022
View reviewed changes
Cargo.toml Show resolved Hide resolved
sistemd
sistemd reviewed Aug 22, 2022
View reviewed changes
src/signer.rs Show resolved Hide resolved
@HarryET
Copy link
Contributor Author

HarryET commented Aug 22, 2022

This PR is waiting for @jrconlin's PR from the Mozilla Service's repo before we cary on so that I'm not writing the same fixes they are.

@jrconlin
Copy link
Contributor

you could probably land this one and I can merge the changes in localized.rs and the others. This looks like it's mostly updating code.

(Sorry, been busy with other projects. Will try to get the PR done this week.)

@HarryET
Copy link
Contributor Author

HarryET commented Aug 23, 2022

you could probably land this one and I can merge the changes in localized.rs and the others. This looks like it's mostly updating code.

(Sorry, been busy with other projects. Will try to get the PR done this week.)

👍🏼 Also looking at #62 to try get this into v0.7, will double check you changes and if non breaking I'll merge this and just release a v0.7.1 afterwards with you changes.

@HarryET HarryET marked this pull request as ready for review December 22, 2022 14:08
xav
xav approved these changes Dec 22, 2022
View reviewed changes
Copy link

@xav xav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is OSS, can we add a .editorconfig while we're at it?

@HarryET
Copy link
Contributor Author

HarryET commented Dec 22, 2022

Since this is OSS, can we add a .editorconfig while we're at it?

I'll make an issue and add this later

heilhead
heilhead approved these changes Dec 22, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@HarryET HarryET merged commit e975867 into master Dec 22, 2022
@HarryET HarryET mentioned this pull request Dec 22, 2022
Merged
3 tasks
@chris13524 chris13524 deleted the v0.7 branch April 26, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sistemd sistemd sistemd left review comments

@xav xav xav approved these changes

@heilhead heilhead heilhead approved these changes

@pimeys pimeys Awaiting requested review from pimeys

@arein arein Awaiting requested review from arein

@Rakowskiii Rakowskiii Awaiting requested review from Rakowskiii

Assignees

@HarryET HarryET

Labels
enhancement refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@HarryET @jrconlin @pimeys @xav @arein @heilhead @sistemd @boxdot