forked from rubocop/rubocop
/
redundant_parentheses_spec.rb
510 lines (429 loc) · 14 KB
/
redundant_parentheses_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::RedundantParentheses, :config do
shared_examples 'redundant' do |expr, correct, type|
it "registers an offense for parentheses around #{type}" do
expect_offense(<<~RUBY, expr: expr)
%{expr}
^{expr} Don't use parentheses around #{type}.
RUBY
expect_correction(<<~RUBY)
#{correct}
RUBY
end
end
shared_examples 'plausible' do |expr|
it 'accepts parentheses when arguments are unparenthesized' do
expect_no_offenses(expr)
end
end
shared_examples 'keyword with return value' do |keyword|
it_behaves_like 'redundant', "(#{keyword})", keyword, 'a keyword'
it_behaves_like 'redundant', "(#{keyword}())", "#{keyword}()", 'a keyword'
it_behaves_like 'redundant', "(#{keyword}(1))", "#{keyword}(1)", 'a keyword'
it_behaves_like 'plausible', "(#{keyword} 1, 2)"
end
shared_examples 'keyword with arguments' do |keyword|
it_behaves_like 'redundant', "(#{keyword})", keyword, 'a keyword'
it_behaves_like 'redundant', "(#{keyword}())", "#{keyword}()", 'a keyword'
it_behaves_like 'redundant', "(#{keyword}(1, 2))", "#{keyword}(1, 2)", 'a keyword'
it_behaves_like 'plausible', "(#{keyword} 1, 2)"
end
it_behaves_like 'redundant', '("x")', '"x"', 'a literal'
it_behaves_like 'redundant', '("#{x}")', '"#{x}"', 'a literal'
it_behaves_like 'redundant', '(:x)', ':x', 'a literal'
it_behaves_like 'redundant', '(:"#{x}")', ':"#{x}"', 'a literal'
it_behaves_like 'redundant', '(1)', '1', 'a literal'
it_behaves_like 'redundant', '(1.2)', '1.2', 'a literal'
it_behaves_like 'redundant', '({})', '{}', 'a literal'
it_behaves_like 'redundant', '([])', '[]', 'a literal'
it_behaves_like 'redundant', '(nil)', 'nil', 'a literal'
it_behaves_like 'redundant', '(true)', 'true', 'a literal'
it_behaves_like 'redundant', '(false)', 'false', 'a literal'
it_behaves_like 'redundant', '(/regexp/)', '/regexp/', 'a literal'
it_behaves_like 'redundant', '("x"; "y")', '"x"; "y"', 'a literal'
it_behaves_like 'redundant', '(1; 2)', '1; 2', 'a literal'
it_behaves_like 'redundant', '(1i)', '1i', 'a literal'
it_behaves_like 'redundant', '(1r)', '1r', 'a literal'
it_behaves_like 'redundant', '(__FILE__)', '__FILE__', 'a keyword'
it_behaves_like 'redundant', '(__LINE__)', '__LINE__', 'a keyword'
it_behaves_like 'redundant', '(__ENCODING__)', '__ENCODING__', 'a keyword'
it_behaves_like 'redundant', '(redo)', 'redo', 'a keyword'
it_behaves_like 'redundant', '(retry)', 'retry', 'a keyword'
it_behaves_like 'redundant', '(self)', 'self', 'a keyword'
context 'ternaries' do
let(:other_cops) do
{
'Style/TernaryParentheses' => {
'Enabled' => ternary_parentheses_enabled,
'EnforcedStyle' => ternary_parentheses_enforced_style
}
}
end
let(:ternary_parentheses_enabled) { true }
let(:ternary_parentheses_enforced_style) { nil }
context 'when Style/TernaryParentheses is not enabled' do
let(:ternary_parentheses_enabled) { false }
it 'registers an offense for parens around constant ternary condition' do
expect_offense(<<~RUBY)
(X) ? Y : N
^^^ Don't use parentheses around a constant.
(X)? Y : N
^^^ Don't use parentheses around a constant.
RUBY
expect_correction(<<~RUBY)
X ? Y : N
X ? Y : N
RUBY
end
end
context 'when Style/TernaryParentheses has EnforcedStyle: require_no_parentheses' do
let(:ternary_parentheses_enforced_style) { 'require_no_parentheses' }
it 'registers an offense for parens around ternary condition' do
expect_offense(<<~RUBY)
(X) ? Y : N
^^^ Don't use parentheses around a constant.
(X)? Y : N
^^^ Don't use parentheses around a constant.
RUBY
expect_correction(<<~RUBY)
X ? Y : N
X ? Y : N
RUBY
end
end
context 'when Style/TernaryParentheses has EnforcedStyle: require_parentheses' do
let(:ternary_parentheses_enforced_style) { 'require_parentheses' }
it_behaves_like 'plausible', '(X) ? Y : N'
end
context 'when Style/TernaryParentheses has EnforcedStyle: require_parentheses_when_complex' do
let(:ternary_parentheses_enforced_style) { 'require_parentheses_when_complex' }
it_behaves_like 'plausible', '(X) ? Y : N'
end
end
it_behaves_like 'keyword with return value', 'break'
it_behaves_like 'keyword with return value', 'next'
it_behaves_like 'keyword with return value', 'return'
it_behaves_like 'keyword with arguments', 'super'
it_behaves_like 'keyword with arguments', 'yield'
it_behaves_like 'redundant', '(defined?(:A))', 'defined?(:A)', 'a keyword'
it_behaves_like 'plausible', '(defined? :A)'
it_behaves_like 'plausible', '(alias a b)'
it_behaves_like 'plausible', '(not 1)'
it_behaves_like 'plausible', '(a until b)'
it_behaves_like 'plausible', '(a while b)'
it 'registers an offense for parens around a variable after semicolon' do
expect_offense(<<~RUBY)
x = 1; (x)
^^^ Don't use parentheses around a variable.
RUBY
expect_correction(<<~RUBY)
x = 1; x
RUBY
end
it_behaves_like 'redundant', '(@x)', '@x', 'a variable'
it_behaves_like 'redundant', '(@@x)', '@@x', 'a variable'
it_behaves_like 'redundant', '($x)', '$x', 'a variable'
it_behaves_like 'redundant', '(X)', 'X', 'a constant'
it_behaves_like 'redundant', '(x)', 'x', 'a method call'
it_behaves_like 'redundant', '(x(1, 2))', 'x(1, 2)', 'a method call'
it_behaves_like 'redundant', '("x".to_sym)', '"x".to_sym', 'a method call'
it_behaves_like 'redundant', '("x"&.to_sym)', '"x"&.to_sym', 'a method call'
it_behaves_like 'redundant', '(x[:y])', 'x[:y]', 'a method call'
it_behaves_like 'redundant', '("foo"[0])', '"foo"[0]', 'a method call'
it_behaves_like 'redundant', '(["foo"][0])', '["foo"][0]', 'a method call'
it_behaves_like 'redundant', '({0 => :a}[0])', '{0 => :a}[0]', 'a method call'
it_behaves_like 'redundant', '(x; y)', 'x; y', 'a method call'
it_behaves_like 'redundant', '(!x)', '!x', 'an unary operation'
it_behaves_like 'redundant', '(~x)', '~x', 'an unary operation'
it_behaves_like 'redundant', '(-x)', '-x', 'an unary operation'
it_behaves_like 'redundant', '(+x)', '+x', 'an unary operation'
it_behaves_like 'plausible', '(!x.m arg)'
it_behaves_like 'plausible', '(!x).y'
it_behaves_like 'plausible', '-(1.foo)'
it_behaves_like 'plausible', '+(1.foo)'
it_behaves_like 'plausible', '-(1.foo.bar)'
it_behaves_like 'plausible', '+(1.foo.bar)'
it_behaves_like 'plausible', '()'
it 'registers an offense for parens around a receiver of a method call with an argument' do
expect_offense(<<~RUBY)
(x).y(z)
^^^ Don't use parentheses around a method call.
RUBY
expect_correction(<<~RUBY)
x.y(z)
RUBY
end
it 'registers an offense for parens around an interpolated expression' do
expect_offense(<<~RUBY)
"\#{(foo)}"
^^^^^ Don't use parentheses around an interpolated expression.
RUBY
expect_correction(<<~RUBY)
"\#{foo}"
RUBY
end
it 'registers an offense for parens around a literal in array' do
expect_offense(<<~RUBY)
[(1)]
^^^ Don't use parentheses around a literal.
RUBY
expect_correction(<<~RUBY)
[1]
RUBY
end
it 'registers an offense for parens around a literal in array and following newline' do
expect_offense(<<~RUBY)
[(1
^^ Don't use parentheses around a literal.
)]
RUBY
expect_correction(<<~RUBY)
[1
]
RUBY
end
it_behaves_like 'plausible', "[(1\n),]"
it_behaves_like 'plausible', <<~RUBY
[
(
1
),
2
]
RUBY
it_behaves_like 'plausible', <<~RUBY
[
x = (
1
),
y = 2
]
RUBY
it 'registers an offense for parens around a literal hash value' do
expect_offense(<<~RUBY)
{a: (1)}
^^^ Don't use parentheses around a literal.
RUBY
expect_correction(<<~RUBY)
{a: 1}
RUBY
end
it 'registers an offense for parens around a literal hash value and following newline' do
expect_offense(<<~RUBY)
{a: (1
^^ Don't use parentheses around a literal.
)}
RUBY
expect_correction(<<~RUBY)
{a: 1
}
RUBY
end
it_behaves_like 'plausible', "{a: (1\n),}"
it 'registers an offense for parens around an integer exponentiation base' do
expect_offense(<<~RUBY)
(0)**2
^^^ Don't use parentheses around a literal.
(2)**2
^^^ Don't use parentheses around a literal.
RUBY
expect_correction(<<~RUBY)
0**2
2**2
RUBY
end
it 'registers an offense for parens around a float exponentiation base' do
expect_offense(<<~RUBY)
(2.1)**2
^^^^^ Don't use parentheses around a literal.
RUBY
expect_correction(<<~RUBY)
2.1**2
RUBY
end
it 'registers an offense for parens around a negative exponent' do
expect_offense(<<~RUBY)
2**(-2)
^^^^ Don't use parentheses around a literal.
RUBY
expect_correction(<<~RUBY)
2**-2
RUBY
end
it 'registers an offense for parens around a positive exponent' do
expect_offense(<<~RUBY)
2**(2)
^^^ Don't use parentheses around a literal.
RUBY
expect_correction(<<~RUBY)
2**2
RUBY
end
it_behaves_like 'plausible', '(-2)**2'
it_behaves_like 'plausible', '(-2.1)**2'
it_behaves_like 'plausible', 'x = (foo; bar)'
it_behaves_like 'plausible', 'x += (foo; bar)'
it_behaves_like 'plausible', 'x + (foo; bar)'
it_behaves_like 'plausible', 'x((foo; bar))'
it 'registers an offense for parens around method body' do
expect_offense(<<~RUBY)
def x
(foo; bar)
^^^^^^^^^^ Don't use parentheses around a method call.
end
RUBY
expect_correction(<<~RUBY)
def x
foo; bar
end
RUBY
end
it 'registers an offense for parens around last expressions in method body' do
expect_offense(<<~RUBY)
def x
baz
(foo; bar)
^^^^^^^^^^ Don't use parentheses around a method call.
end
RUBY
expect_correction(<<~RUBY)
def x
baz
foo; bar
end
RUBY
end
it 'registers an offense for parens around a block body' do
expect_offense(<<~RUBY)
x do
(foo; bar)
^^^^^^^^^^ Don't use parentheses around a method call.
end
RUBY
expect_correction(<<~RUBY)
x do
foo; bar
end
RUBY
end
it 'registers an offense for parens around last expressions in block body' do
expect_offense(<<~RUBY)
x do
baz
(foo; bar)
^^^^^^^^^^ Don't use parentheses around a method call.
end
RUBY
expect_correction(<<~RUBY)
x do
baz
foo; bar
end
RUBY
end
it 'accepts parentheses around a method call with unparenthesized arguments' do
expect_no_offenses('(a 1, 2) && (1 + 1)')
end
it 'accepts parentheses inside an irange' do
expect_no_offenses('(a)..(b)')
end
it 'accepts parentheses inside an erange' do
expect_no_offenses('(a)...(b)')
end
it 'accepts parentheses around an irange' do
expect_no_offenses('(a..b)')
end
it 'accepts parentheses around an erange' do
expect_no_offenses('(a...b)')
end
it 'accepts parentheses around operator keywords' do
expect_no_offenses('(1 and 2) and (3 or 4)')
end
it 'registers an offense when there is space around the parentheses' do
expect_offense(<<~RUBY)
if x; y else (1) end
^^^ Don't use parentheses around a literal.
RUBY
end
it 'accepts parentheses when enclosed in parentheses at `while-post`' do
expect_no_offenses(<<~RUBY)
begin
do_something
end while(bar)
RUBY
end
it 'accepts parentheses when enclosed in parentheses at `until-post`' do
expect_no_offenses(<<~RUBY)
begin
do_something
end until(bar)
RUBY
end
it 'accepts parentheses when they touch the preceding keyword' do
expect_no_offenses('if x; y else(1) end')
end
it 'accepts parentheses when they touch the following keyword' do
expect_no_offenses('if x; y else (1)end')
end
context 'when the first argument in a method call begins with a hash literal' do
it 'accepts parentheses if the argument list is not parenthesized' do
expect_no_offenses('x ({ y: 1 }), z')
expect_no_offenses('x ({ y: 1 }.merge({ y: 2 })), z')
expect_no_offenses('x ({ y: 1 }.merge({ y: 2 }).merge({ y: 3 })), z')
end
it 'registers an offense if the argument list is parenthesized' do
expect_offense(<<~RUBY)
x(({ y: 1 }), z)
^^^^^^^^^^ Don't use parentheses around a literal.
RUBY
end
end
context 'when a hash literal is the second argument in a method call' do
it 'registers an offense' do
expect_offense(<<~RUBY)
x ({ y: 1 }), ({ y: 1 })
^^^^^^^^^^ Don't use parentheses around a literal.
RUBY
end
end
context 'when a non-parenthesized call has an arg and a block' do
it 'accepts parens around the arg' do
expect_no_offenses('method (:arg) { blah }')
end
end
context 'when parentheses are used like method argument parentheses' do
it 'accepts parens around the arg' do
expect_no_offenses('method (arg)')
end
end
it 'accepts parentheses around the error passed to rescue' do
expect_no_offenses(<<~RUBY)
begin
some_method
rescue(StandardError)
end
RUBY
end
it 'accepts parentheses around a constant passed to when' do
expect_no_offenses(<<~RUBY)
case foo
when(Const)
bar
end
RUBY
end
it 'accepts parentheses in super call with hash' do
expect_no_offenses(<<~RUBY)
super ({
foo: bar,
})
RUBY
end
it 'accepts parentheses in yield call with hash' do
expect_no_offenses(<<~RUBY)
yield ({
foo: bar,
})
RUBY
end
end