-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should add the checking subscriber's active
state to the first step of next(value)
/error(error)
/complete()
methods?
#114
Comments
Checking algorithm step null-ness vs checking Does that make sense? |
By subscribe to an Observable concept, the steps 2 lets a new internal observer and it will be used to initialize subscriber in the step 5.
But internal observer has initial value but I read they does not means null:
From these definitions of the current spec and other parts, I seem next/error/complete algorithm would not be null without steps in close a subscription concept. |
Looks like you're right, good catch! Feel free to send a PR my way to clean this up in the spec, if you'd like. |
These supporting concepts does not check subscriber's active state.
And they use as null checking for each of next/error/complete algorithm instead of checking active concept, because of close a subscription concept set active to
false
and set next/error/complete algorithm to null.However, I feel it's an implicit steps. I also think it's better to use active concept and checking it at the first step of each of subscriber's next(value) / error(error) / complete() concepts.
The text was updated successfully, but these errors were encountered: