Skip to content

bump version and dependabot updates #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2022
Merged

bump version and dependabot updates #184

merged 1 commit into from
Jun 8, 2022

Conversation

bkardell
Copy link
Collaborator

@bkardell bkardell commented Jun 8, 2022

Bumps the version a minor release and fixes all of the dependabot warnings should close: #179, #177, #175, #162, #160, #147, #142, #140 - basically everything tagged as dependencies.

Ah I should note that the sauce labs tests should probably be reviewed, there are consistently the same 11 failures on any browser that supports inert natively now and it's because the polyfill itself checks for support and doesn't add itself if things are supported - but the tests check for approximations not previously possible directly without native support... So, for example, a div that was tabindex=0 would have that attribute removed on an ancestor becomming inert and readded later. Obviously that won't happen with native inert... It looks like all of these are consistent and predictable across the implementations and don't indicate a problem with the polyfill, just the tests.

@bkardell bkardell requested review from robdodson, alice and yoavweiss June 8, 2022 19:02
@robdodson robdodson merged commit 3f566d1 into main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants